[ssip]: Add CLI #2191

nazariig · 2022-05-31T18:06:26Z

HLD: sonic-net/SONiC#1002

What I did

Implemented CLI for Syslog Source IP

How I did it

N/A

How to verify it

N/A

Previous command output (if the output of a command-line utility has changed)

N/A

New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# show syslog
SERVER IP    SOURCE IP    PORT    VRF
-----------  -----------  ------  --------
2.2.2.2      1.1.1.1      514     default
3.3.3.3      1.1.1.1      514     mgmt
2222::2222   1111::1111   514     Vrf-Data

nazariig · 2022-05-31T22:04:02Z

/azpw run

mssonicbld · 2022-05-31T22:04:03Z

/AzurePipelines run

azure-pipelines · 2022-05-31T22:04:13Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2022-06-20T06:30:34Z

config/main.py

@@ -4970,6 +4974,12 @@ def del_vrf(ctx, vrf_name):
        ctx.fail("'vrf_name' is not start with Vrf, mgmt or management!")
    if len(vrf_name) > 15:
        ctx.fail("'vrf_name' is too long!")
+    syslog_table = config_db.get_table("SYSLOG_SERVER")
+    syslog_vrf_dev = "mgmt" if vrf_name == "management" else vrf_name


vrf_name

@prsunny, Could you check VRF related part?

lgtm, minor comment: Later part of the syslog implementation checks for the presence of 'source_ip' in linux during add operation. But this is not checked during an ip address delete. Is this intentional or am i missing something?

@prsunny you are right, this is intentionally. The reason for that is because we don't reference IP in Config DB, so there is no point to check

@prsunny can you please approve if no more questions

Signed-off-by: Nazarii Hnydyn <[email protected]>

show/main.py

Signed-off-by: Nazarii Hnydyn <[email protected]>

liat-grozovik · 2022-07-09T13:51:01Z

Are there any such examples in current sonic arch? If not I don't think we should go there unless we decide to move to a different way in sonic and for that I don't think we should use this specific implementation to discuss it Get Outlook for iOS<https://aka.ms/o0ukef>

________________________________ From: Nazarii Hnydyn ***@***.***> Sent: Saturday, July 9, 2022 4:44:25 PM To: Azure/sonic-utilities ***@***.***> Cc: Liat Grozovik ***@***.***>; Review requested ***@***.***> Subject: Re: [Azure/sonic-utilities] [ssip]: Add CLI (PR #2191) @nazariig commented on this pull request.

________________________________ In show/main.py<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-utilities%2Fpull%2F2191%23discussion_r917270130&data=05%7C01%7Cliatg%40nvidia.com%7Cd71b09f30f434792387408da61b1236c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637929710677475944%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=DaDB2pqGMMHJBdsDmZtJ5j52j1sJYgtKMthYp3Zjljs%3D&reserved=0>:

- re_ipv6 = re.compile(r'^\*\.\* @{1,2}\[([0-9a-fA-F:.]+)\](:\d+)?')

- with open("/etc/rsyslog.conf") as syslog_file: - data = syslog_file.readlines() - for line in data: - if re_ipv4_1.match(line): - server = re_ipv4_1.match(line).group(1) - elif re_ipv4_2.match(line): - server = re_ipv4_2.match(line).group(1) - elif re_ipv6.match(line): - server = re_ipv6.match(line).group(1) - else: - continue - syslog_servers.append("[{}]".format(server)) - syslog_dict['Syslog Servers'] = syslog_servers - print(tabulate(syslog_dict, headers=list(syslog_dict.keys()), tablefmt="simple", stralign='left', missingval="")) ***@***.***_db @qiluo-msft<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fqiluo-msft&data=05%7C01%7Cliatg%40nvidia.com%7Cd71b09f30f434792387408da61b1236c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637929710677475944%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=5%2FimwAa69SnP6%2FQdkZ9A4d4mVz5Irt020cxL17TqPp8%3D&reserved=0> IMHO, parsing generated files with regex for "running" config is an overhead. Still, if you believe that this is more reliable way - please let me know and i will align. P.S: if we want to follow such an approach (instead of Config DB), would be great to define some kind of doc to explain where and how it supposed to be used. — Reply to this email directly, view it on GitHub<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-utilities%2Fpull%2F2191%23discussion_r917270130&data=05%7C01%7Cliatg%40nvidia.com%7Cd71b09f30f434792387408da61b1236c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637929710677475944%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=DaDB2pqGMMHJBdsDmZtJ5j52j1sJYgtKMthYp3Zjljs%3D&reserved=0>, or unsubscribe<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKTABA6J66OU4NOFHQ4HOHLVTF63TANCNFSM5XOMPCFQ&data=05%7C01%7Cliatg%40nvidia.com%7Cd71b09f30f434792387408da61b1236c%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637929710677475944%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wr14ppV3H9MR2k5R0vqhDhxbLm%2FRBs1tXqZonwqQmQY%3D&reserved=0>. You are receiving this because your review was requested.Message ID: ***@***.***>

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig · 2022-07-13T17:50:54Z

@wen587 / @qiluo-msft please sign-off if no more concerns

wen587 · 2022-07-14T02:36:43Z

LGTM

nazariig mentioned this pull request May 31, 2022

[ssip]: Syslog Source IP configuration HLD sonic-net/SONiC#1002

Merged

nazariig force-pushed the master-ssip branch from 73665b9 to 425343d Compare June 1, 2022 17:33

nazariig requested review from liat-grozovik and volodymyrsamotiy June 7, 2022 10:14

qiluo-msft requested a review from wen587 June 20, 2022 06:23

qiluo-msft reviewed Jun 20, 2022

View reviewed changes

qiluo-msft requested a review from prsunny June 20, 2022 06:34

liat-grozovik mentioned this pull request Jun 28, 2022

[Command-Reference] Add CLI docs for IP interface loopback action #2216

Closed

nazariig force-pushed the master-ssip branch from 425343d to e1b9bba Compare July 5, 2022 12:22

nazariig added 7 commits July 5, 2022 15:22

[ssip]: Add show commands.

d7c1421

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: Add config commands.

82ab1e8

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: Code cleanup.

ab79545

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: config commands rev01.

feaace8

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: config commands rev02.

3ac9305

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: config commands rev03.

7550950

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: config commands rev04.

81e2834

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig force-pushed the master-ssip branch 3 times, most recently from ba67de4 to a0d762a Compare July 5, 2022 17:01

wen587 reviewed Jul 6, 2022

View reviewed changes

show/main.py Outdated Show resolved Hide resolved

nazariig force-pushed the master-ssip branch from a0d762a to 27d76eb Compare July 6, 2022 15:37

nazariig added 4 commits July 7, 2022 16:15

[ssip]: config commands rev05.

b6163e2

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: show commands rev01.

ca9e117

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: show commands rev02.

8e71f70

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: show commands rev03.

dd67d94

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig force-pushed the master-ssip branch from 27d76eb to 0ce003e Compare July 7, 2022 13:19

nazariig force-pushed the master-ssip branch from 0ce003e to ca8e722 Compare July 13, 2022 11:40

nazariig added 4 commits July 13, 2022 14:57

[ssip]: show commands rev04.

9fc474c

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: Add CLI UTs.

bf4f189

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: CLI UTs rev01.

713cf95

Signed-off-by: Nazarii Hnydyn <[email protected]>

[ssip]: Update UM.

f39c69e

Signed-off-by: Nazarii Hnydyn <[email protected]>

nazariig force-pushed the master-ssip branch from ca8e722 to f39c69e Compare July 13, 2022 11:58

qiluo-msft approved these changes Jul 17, 2022

View reviewed changes

liat-grozovik merged commit 8e5d478 into sonic-net:master Jul 18, 2022

prsunny mentioned this pull request Jul 21, 2022

[CLI] Move hostname, mgmt interface/vrf config to hostcfgd #2173

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ssip]: Add CLI #2191

[ssip]: Add CLI #2191

nazariig commented May 31, 2022 •

edited

Loading

nazariig commented May 31, 2022

mssonicbld commented May 31, 2022

azure-pipelines bot commented May 31, 2022

qiluo-msft Jun 20, 2022

prsunny Jul 6, 2022

nazariig Jul 6, 2022

nazariig Jul 13, 2022

liat-grozovik commented Jul 9, 2022 via email

nazariig commented Jul 13, 2022

wen587 commented Jul 14, 2022

[ssip]: Add CLI #2191

[ssip]: Add CLI #2191

Conversation

nazariig commented May 31, 2022 • edited Loading

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

nazariig commented May 31, 2022

mssonicbld commented May 31, 2022

azure-pipelines bot commented May 31, 2022

qiluo-msft Jun 20, 2022

Choose a reason for hiding this comment

prsunny Jul 6, 2022

Choose a reason for hiding this comment

nazariig Jul 6, 2022

Choose a reason for hiding this comment

nazariig Jul 13, 2022

Choose a reason for hiding this comment

liat-grozovik commented Jul 9, 2022 via email

nazariig commented Jul 13, 2022

wen587 commented Jul 14, 2022

nazariig commented May 31, 2022 •

edited

Loading