Fix 'show mac' output when FDB entry for default vlan is None instead of 1 #2126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Fixes an issue where VLAN ID of None results in "int() argument must be a string, a bytes-like object or a number, not 'NoneType'" error.
Signed-off-by: James Denton [email protected]
What I did
Fixed "show mac" command execution failure when the system has an FDB entry linked to default Vlan 1 that cannot be looked up (returns None).
How I did it
If VLAN ID is None, assume it is 1 and allow the entry to be listed.
How to verify it
Pass traffic through an unconfigured interface and perform a 'show mac' or 'fdbshow' command.
Previous command output (if the output of a command-line utility has changed)
admin@sonic:~$ show mac
int() argument must be a string, a bytes-like object or a number, not 'NoneType'
New command output (if the output of a command-line utility has changed)
admin@sonic:~$ show mac
No. Vlan MacAddress Port Type
10 20 00:16:3E:50:A3:35 Ethernet2 Dynamic
11 20 00:16:3E:1A:74:BD Ethernet2 Dynamic
12 20 00:16:3E:37:EE:EC Ethernet2 Dynamic
13 20 00:16:3E:5A:71:A2 Ethernet2 Dynamic