Skip to content

[ci] Use official build debian pkg instead and parameterize source branch. #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

liushilongbuaa
Copy link
Contributor

@liushilongbuaa liushilongbuaa commented Feb 22, 2022

What I did

  1. Use official build debian pkg.
  2. parameterize download source branch for future release branch.

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@liushilongbuaa liushilongbuaa changed the title test [ci] Use official build debian pkg instead and parameterize source branch. Feb 23, 2022
@liushilongbuaa liushilongbuaa marked this pull request as ready for review February 23, 2022 02:55
@qiluo-msft
Copy link
Contributor

qiluo-msft commented Feb 23, 2022

Will override vstest failure to fix download pipeline index for each branches, including master.

@qiluo-msft qiluo-msft merged commit 25b3455 into sonic-net:master Feb 23, 2022
@ghooo
Copy link
Contributor

ghooo commented Feb 23, 2022

Will override vstest failure to fix master build.

@qiluo-msft For my understanding, I think this PR is not impacting builds that are on top of master branch. It is affecting builds that are on top on other branches like 202111. Looking at the logs of this PR I see the following

Download artifact branch: master

So it is not changing.

The builds in master branch in sonic-utils will pass Test Python 3 now because we have master branch branch successful build.
https://dev.azure.com/mssonic/build/_build/results?buildId=74810&view=results

[Update] Offline discussion: the change of the pipeline from 1->142 will impact master sonic-utils branch builds.

@liushilongbuaa
Copy link
Contributor Author

liushilongbuaa commented Feb 23, 2022

@ghooo yes, this PR will not change the download branch for sonic-utilities master branch. It will work for future release branches.
Former two builds on pipeline 1 failed for unknown reason, so it's better to use pipeline 142. There are two main reason: 1. pipeline 142 don't use cache, so it is more clean. 2. pipeline 1 run a build for each commit, any breaking PR merging will impact sonic-utilities job.

@ghooo
Copy link
Contributor

ghooo commented Feb 23, 2022

@liushilongbuaa got it, thanks for the detailed explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants