-
Notifications
You must be signed in to change notification settings - Fork 711
Fix wrong help message for cable length setting #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
liat-grozovik
merged 1 commit into
sonic-net:master
from
dprital:fix_interface_cable_message
Dec 28, 2021
Merged
Fix wrong help message for cable length setting #1978
liat-grozovik
merged 1 commit into
sonic-net:master
from
dprital:fix_interface_cable_message
Dec 28, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenxs
approved these changes
Dec 20, 2021
/azpw run Azure.sonic-utilities (Test vstest) ,Azure.sonic-utilities |
/AzurePipelines run Azure.sonic-utilities (Test vstest) ,Azure.sonic-utilities |
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Dec 20, 2021
/azpw run Azure.sonic-utilities (Test vstest) ,Azure.sonic-utilities |
/AzurePipelines run Azure.sonic-utilities (Test vstest) ,Azure.sonic-utilities |
Azure Pipelines successfully started running 1 pipeline(s). |
judyjoseph
pushed a commit
that referenced
this pull request
Jan 9, 2022
- What I did Replace the wrong help message of "Set lossless PGs for the interface" with the right one "Set interface cable length" - How I did it Update the help message to the relevant one on main.py - How to verify it Run the following command: "config interface cable-length Ethernet0 -h" - Previous command output (if the output of a command-line utility has changed) Set lossless PGs for the interface - New command output (if the output of a command-line utility has changed) Set interface cable length
arlakshm
pushed a commit
that referenced
this pull request
Mar 1, 2022
- What I did Replace the wrong help message of "Set lossless PGs for the interface" with the right one "Set interface cable length" - How I did it Update the help message to the relevant one on main.py - How to verify it Run the following command: "config interface cable-length Ethernet0 -h" - Previous command output (if the output of a command-line utility has changed) Set lossless PGs for the interface - New command output (if the output of a command-line utility has changed) Set interface cable length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Replace the wrong help message of "Set lossless PGs for the interface" with the right one "Set interface cable length"
How I did it
Update the help message to the relevant one on main.py
How to verify it
Run the following command: "config interface cable-length Ethernet0 -h"
Previous command output (if the output of a command-line utility has changed)
Set lossless PGs for the interface
New command output (if the output of a command-line utility has changed)
Set interface cable length