Skip to content

Fix wrong help message for cable length setting #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

dprital
Copy link
Collaborator

@dprital dprital commented Dec 20, 2021

What I did

Replace the wrong help message of "Set lossless PGs for the interface" with the right one "Set interface cable length"

How I did it

Update the help message to the relevant one on main.py

How to verify it

Run the following command: "config interface cable-length Ethernet0 -h"

Previous command output (if the output of a command-line utility has changed)

Set lossless PGs for the interface

New command output (if the output of a command-line utility has changed)

Set interface cable length

@dprital
Copy link
Collaborator Author

dprital commented Dec 20, 2021

/azpw run Azure.sonic-utilities (Test vstest) ,Azure.sonic-utilities

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-utilities (Test vstest) ,Azure.sonic-utilities

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dprital
Copy link
Collaborator Author

dprital commented Dec 21, 2021

/azpw run Azure.sonic-utilities (Test vstest) ,Azure.sonic-utilities

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-utilities (Test vstest) ,Azure.sonic-utilities

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit fbd565d into sonic-net:master Dec 28, 2021
judyjoseph pushed a commit that referenced this pull request Jan 9, 2022
- What I did
Replace the wrong help message of "Set lossless PGs for the interface" with the right one "Set interface cable length"

- How I did it
Update the help message to the relevant one on main.py

- How to verify it
Run the following command: "config interface cable-length Ethernet0 -h"

- Previous command output (if the output of a command-line utility has changed)
Set lossless PGs for the interface

- New command output (if the output of a command-line utility has changed)
Set interface cable length
arlakshm pushed a commit that referenced this pull request Mar 1, 2022
- What I did
Replace the wrong help message of "Set lossless PGs for the interface" with the right one "Set interface cable length"

- How I did it
Update the help message to the relevant one on main.py

- How to verify it
Run the following command: "config interface cable-length Ethernet0 -h"

- Previous command output (if the output of a command-line utility has changed)
Set lossless PGs for the interface

- New command output (if the output of a command-line utility has changed)
Set interface cable length
@dprital dprital deleted the fix_interface_cable_message branch May 11, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants