Fix ConfigDBConnector import in pg-drop script #1779
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
202012 PR tests are failing consistently. The failure is seen in
tests/pgdropstat_test.py
This is a new test that was originally added to master branch, and cherrypicked into 202012 where it started failing.Related PR: #1678
The import mechanism for
ConfigDBConnector
is incorrect and that fails the PR tests on 202012 branch. The tests succeed on master branch with the original change.How I did it
Update
ConfigDBConnector
import from swss-common to swsssdk.How to verify it
PR tests for 202012 target branch are passing now.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)