Skip to content

[show][config] cli support for firmware upgrade on Y-Cable (#1528) #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

vdahiya12
Copy link
Contributor

@vdahiya12 vdahiya12 commented Apr 12, 2021

Summary:
This PR provides the support for adding CLI commands for activate, download, upgrade firmware on the Y-cable
In particular these Cli commands are supported:
sudo config muxcable firmware download Ethernet0
sudo config muxcable firmware rollback Ethernet0
sudo config muxcable firmware download ~/AEC_WYOMING_B52Yb0_MS_0.6_20201218.bin Ethernet0

Signed-off-by: vaibhav-dahiya [email protected]

What I did

Added the support for firmware upgrade CLI on Y cable

How I did it

added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py

admin@STR43-0101-0101-01LT0:/usr$ sudo config muxcable firmware download ~/AEC_WYOMING_B52Yb0_MS_0.6_20201218.bin Ethernet0
firmware download successful Ethernet0

admin@STR43-0101-0101-01LT0:~/credo_script_01_21$ sudo config muxcable firmware activate Ethernet0
firmware activate successful Ethernet0

admin@STR43-0101-0101-01LT0:~/credo_script_01_21$ sudo config muxcable firmware rollback Ethernet0
firmware rollback successful Ethernet0

How to verify it

Ran the command on a 7050cx3 arista switch

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

…#1528)

Summary:
This PR provides the support for adding CLI commands for activatie, download, upgrade firmware on the Y-cable
In particular these Cli commands are supported:
sudo config muxcable firmware download Ethernet0
sudo config muxcable firmware rollback Ethernet0
sudo config muxcable firmware download ~/AEC_WYOMING_B52Yb0_MS_0.6_20201218.bin Ethernet0

Signed-off-by: vaibhav-dahiya [email protected]

What I did
Added the support for firmware upgrade CLI on Y cable

How I did it
added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py

Signed-off-by: vaibhav-dahiya <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Apr 12, 2021

This pull request introduces 1 alert when merging 534bdc3 into 9af50fe - view on LGTM.com

new alerts:

  • 1 for Unused import

Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
@vdahiya12 vdahiya12 merged commit 4f5bbbe into sonic-net:202012 Apr 15, 2021
vdahiya12 added a commit that referenced this pull request Apr 29, 2021
…#1584)

For 202012 branch ConfigDBConnector() is imported from swsssdk.
So to use ConfigDBConnector() we still have to import from swsssdk instead of swsscommon.
The #1558 changed ConfigDBConnector() to be imported from swsscommon in show/muxcable.py
which causes unit test failure in sonic-utilities.
This PR fixes that.

Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant