cache the bvid to vlan translations #1523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add lookup table for bvid to vlan translations.
|
|
prsunny
reviewed
Mar 25, 2021
qiluo-msft
reviewed
Mar 25, 2021
| else: | ||
| try: | ||
| vlan_id = port_util.get_vlan_id_from_bvid(self.db, bvid) | ||
| if vlan_id is None: |
There was a problem hiding this comment.
if vlan_id is None: [](start = 24, length = 19)
Even if vlan_id is None, you can still cache it to save future redis access.
There was a problem hiding this comment.
Agree, updated patch
prsunny
reviewed
Mar 26, 2021
| @@ -87,6 +87,7 @@ class FdbShow(object): | |||
| if not fdb_str: | |||
| return | |||
|
|
|||
| bvid_tlb = {} | |||
There was a problem hiding this comment.
if you meant bvid table, please rename to bvid_tbl
There was a problem hiding this comment.
I meant Translation lookaside buffer, as in MMU, thus TLB.
qiluo-msft
approved these changes
Mar 26, 2021
|
@qiluo-msft should I do something to complete those expected checks? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Mar 31, 2021
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1523 in repo Azure/sonic-utilities |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
Add lookup table for bvid to vlan translations. bvid_tlb will store previous successful translations from slow get_vlan_id_from_bvid() This patch does not change the output from the command, only speeds up it for case of 10k+ MAC tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lookup table for bvid to vlan translations.
bvid_tlb will store previous successful translations from slow get_vlan_id_from_bvid()
This patch does not change the output from the command, only speeds up it for case of 10k+ MAC tables.