Skip to content

Set untagged VLANs to tagged before adding a new untagged VLAN member… #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tim-rj
Copy link
Contributor

@tim-rj tim-rj commented Dec 23, 2020

… for a port

fix Azure/sonic-buildimage#6271

Check whether the port is already an untagged member of another VLAN
when adding an untagged member to a VLAN. If true, set the previous
one as tagged.

Signed-off-by: tim-rj [email protected]

- What I did

fix Azure/sonic-buildimage#6271

- How I did it

Check whether the port is already an untagged member of another VLAN when adding an untagged member to a VLAN.
If true, set the previous one as tagged.

- How to verify it

1. Adding a port as an untagged VLAN member
2. Adding the same port as an untagged member of another VLAN
3. show vlan brief

- Previous command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# config vlan member add 10 Ethernet11 -u
root@sonic:/home/admin# config vlan member add 20 Ethernet11 -u
root@sonic:/home/admin# show vlan brief
+-----------+--------------+------------+----------------+-----------------------+-------------+
|   VLAN ID | IP Address   | Ports      | Port Tagging   | DHCP Helper Address   | Proxy ARP   |
+===========+==============+============+================+=======================+=============+
|        10 |              | Ethernet11 | untagged       |                       | disabled    |
+-----------+--------------+------------+----------------+-----------------------+-------------+
|        20 |              | Ethernet11 | untagged       |                       | disabled    |
+-----------+--------------+------------+----------------+-----------------------+-------------+

- New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# show vlan brief
+-----------+--------------+------------+----------------+-----------------------+-------------+
|   VLAN ID | IP Address   | Ports      | Port Tagging   | DHCP Helper Address   | Proxy ARP   |
+===========+==============+============+================+=======================+=============+
|        10 |              | Ethernet11 | untagged       |                       | disabled    |
+-----------+--------------+------------+----------------+-----------------------+-------------+
|        20 |              | Ethernet11 | untagged       |                       | disabled    |
+-----------+--------------+------------+----------------+-----------------------+-------------+
root@sonic:/home/admin# config vlan member del 10 Ethernet11
root@sonic:/home/admin# config vlan member add 10 Ethernet11 -u
root@sonic:/home/admin# show vlan brief
+-----------+--------------+------------+----------------+-----------------------+-------------+
|   VLAN ID | IP Address   | Ports      | Port Tagging   | DHCP Helper Address   | Proxy ARP   |
+===========+==============+============+================+=======================+=============+
|        10 |              | Ethernet11 | untagged       |                       | disabled    |
+-----------+--------------+------------+----------------+-----------------------+-------------+
|        20 |              | Ethernet11 | tagged         |                       | disabled    |
+-----------+--------------+------------+----------------+-----------------------+-------------+

… for a port

    fix sonic-net/sonic-buildimage#6271

    Check whether the port is already an untagged member of another VLAN
    when adding an untagged member to a VLAN. If true, set the previous
    one as tagged.

Signed-off-by: tim-rj <[email protected]>
@pettershao-ragilenetworks
Copy link
Contributor

help forward this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants