Skip to content

Fix show ip/v6 route summary on non-multi-asic platforms to let FRR handle it completely #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

gechiang
Copy link
Contributor

@gechiang gechiang commented Dec 11, 2020

- What I did

  1. Changed the handling of "show ip/v6 route xxxx" for non-multi-asic platforms to be handled by FRR completely instead of using the common code added to support multi-asic platform. This is because there are some options such as summary and tables are not yet supported by multi-asic platform and we should not penalize non-multi-asic platform by sharing the same common code.
  2. Due to this change, had to modify/add additional unit tests to ensure good test coverage of > 95%.
  3. Took the opportunity to refactor the expected test data output strings into a standalone file to make the test code easier to read.

- How to verify it
Perform "show ip/v6 route summary" and many other options to ensure that both pizzabox and multi-asic platforms are handling them correctly.
Before the fix:

admin@str-a7050-acs-2:~$ show ip route summary
% Unknown command: show ip route sum 

After the fix:

admin@str-a7050-acs-2:~$ show ip route summary
Route Source         Routes               FIB  (vrf default)
kernel               1                    1                    
connected            26                   26                   
static               1                    0                    
ebgp                 6426                 6425                 
ibgp                 0                    0                    
------
Totals               6454                 6452                 


admin@str-a7050-acs-2:~$

Fix sonic-net/sonic-buildimage#6153

@gechiang gechiang merged commit 980ea0d into sonic-net:master Dec 11, 2020
anand-kumar-subramanian pushed a commit to anand-kumar-subramanian/sonic-utilities that referenced this pull request Mar 2, 2021
Handling of "show ip/v6 route xxxx" for non-multi-asic platforms to be handled by FRR completely instead of using the common code added to support multi-asic platform.
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
 [aclorch] Add support for creating ingress and egress MIRROR tables
 concurrently (sonic-net#1286)
[proxy_arp] Implement proxy ARP feature (sonic-net#1302)
Fix LAG member test case (sonic-net#1304)
[orchagent] Set default MTU for the underlay loopback interface (sonic-net#1299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI] 'show ip route sum' cmd is not available on lattest image
3 participants