-
Notifications
You must be signed in to change notification settings - Fork 710
[config/console][consutil] Support enable/disable console switch #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jleveque, @lguohan want some input from you here:
|
Great ask, I saw we have a FEATURE table already a few days ago and I am entangled too on if use it or follow the HLD. Seems like the FEATURE table have some options for service/container only and most features are not able to configure by minigraph. For the naming convention, we really need that. I try search our doc: https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md and we have both {enable/disable} {enabled/disabled} documented, it would be never late to align them earlier. |
Currently, all entries in the FEATURE table are services which manage a container. I'm not sure if want to extend that to include this "feature". @lguohan to comment.
With regards to the CLI as it currently stands, |
Yes, actually this is a simply binary switch for console CLI, its quite different with a service since it can't 'restart' or 'auto-start'. But the FEATURE table is appropriate from the semantic aspect. Looking forward to your comments @lguohan |
01fe565
to
83dcabf
Compare
…ic-net#1275) * [config/console][consutil] Support enable/disable console switch * Changed the key to aligned with feature table style Signed-off-by: Jing Kan [email protected]
- What I did
This is the implementation of HLD: https://github.com/Azure/SONiC/blob/master/doc/console/SONiC-Console-Switch-High-Level-Design.md#33136-enabledisable-console-switch-feature
This PR will allow user to enable/disable console switch management functions on a SONiC device.
- How I did it
config console {enable/disable}
command- How to verify it
- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)
N/A