[config_mgmt.py]: Set leaf-list to empty list while port breakout. #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please |
|
retest this please |
1 similar comment
|
retest this please |
added 2 commits
January 7, 2021 15:50
Changes: -- Set leaf-list to empty list while port breakout, because deletions are not done to fields once set. -- Minor changes in test file. Signed-off-by: Praveen Chaudhary<[email protected]>
1.) Print whenever doPrint is true, it is needed for all error cases. 2.) Use deepcopy. 3.) Fix tests to accommodate empty string ports of ACL. 4.) Rebase. Signed-off-by: Praveen Chaudhary<[email protected]>
praveen-li
force-pushed
the
set_leaf_list_empty
branch
from
25b2cf1 to
4cf009a
Compare
|
This pull request introduces 1 alert when merging 4cf009a into 0a4365a - view on LGTM.com new alerts:
|
And handle the case where configDb stores [] as [""]. Signed-off-by: Praveen Chaudhary<[email protected]>
|
retest this please |
|
retest this please |
qiluo-msft
reviewed
Jan 21, 2021
qiluo-msft
reviewed
Jan 21, 2021
|
You mentioned "Right now it is not verified because Utils is not build PY3 yet on Azure Master." I think the py3 build is ready. #Closed |
qiluo-msft
reviewed
Jan 21, 2021
Signed-off-by: Praveen Chaudhary <[email protected]>
Fixed: Ideally, it should say, Build depends on #6029 |
qiluo-msft
approved these changes
Jan 21, 2021
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…onic-net#1268) -- Set leaf-list to empty list while port breakout, because deletions are not done to fields once set. -- Minor changes in test file. Signed-off-by: Praveen Chaudhary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
-- Set leaf-list to empty list while port breakout, because deletions
are not done to fields once set.
Signed-off-by: Praveen Chaudhary[email protected]
Depends on sonic-net/sonic-buildimage#6029
- What I did
Changes:
-- Set leaf-list to empty list while port breakout, because deletions
are not done to fields once set.
- How I did it
Set list to empty while DPB.
- How to verify it
Build time tests are changes accordingly. PKGs build fine.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)