Skip to content

show tech with platform dump option #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 15, 2020
Merged

Conversation

sujinmkang
Copy link
Collaborator

@sujinmkang sujinmkang commented Oct 10, 2020

- What I did
Add an option to force the hardware register dump with -f for show techsupport --allow-process-stop
- How I did it
Add an option '--allow-process-stop' to show techsupport cli command and '-a' to generate_dump script
- How to verify it
Perform show techsupport --allow-process-stop to collect extra hardware registers information which may require system interruption.
- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)
N/A

@sujinmkang sujinmkang marked this pull request as ready for review November 18, 2020 01:55
@sujinmkang sujinmkang requested a review from jleveque November 18, 2020 01:55
@sujinmkang
Copy link
Collaborator Author

@jleveque Can you review this change again?

@lgtm-com
Copy link

lgtm-com bot commented Dec 9, 2020

This pull request introduces 1 alert and fixes 5 when merging 92dea9f into 57a0b41 - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 4 for Module-level cyclic import
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Dec 10, 2020

This pull request introduces 1 alert and fixes 5 when merging 39833a7 into 57a0b41 - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 4 for Module-level cyclic import
  • 1 for Unused import

@jleveque
Copy link
Contributor

Retest this please

@sujinmkang sujinmkang merged commit 6dd5d31 into sonic-net:master Dec 15, 2020
anand-kumar-subramanian pushed a commit to anand-kumar-subramanian/sonic-utilities that referenced this pull request Mar 2, 2021
- What I did
Add an option to force the hardware register dump with -f for show techsupport --allow-process-stop
- How I did it
Add an option '--allow-process-stop' to show techsupport cli command and '-a' to generate_dump script
- How to verify it
Perform show techsupport --allow-process-stop to collect extra hardware registers information which may require system interruption.
- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants