Skip to content

[teamshow] Remove 't' from argument when calling docker exec #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

bingwang-ms
Copy link
Contributor

- What I did
teamshow reads teams raw data by running docker exec -it xxx. However, the 't' may lead to error when called without a tty. This commit fix the issue.
- How I did it
Remove 't' from argument when calling docker exec.
- How to verify it
Verified on Arista 7260.
before update:

ssh [email protected] "SONIC_CLI_IFACE_MODE=alias sudo show interfaces portchannel" 
Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not available,
       S - selected, D - deselected, * - not synced
  No.  Team Dev         Protocol    Ports
-----  ---------------  ----------  -------
 0001  PortChannel0001  N/A
 0002  PortChannel0002  N/A
 0003  PortChannel0003  N/A
 0004  PortChannel0004  N/A

We can see that the Protocols and Ports are invalid.
after update:

ssh -t [email protected] "SONIC_CLI_IFACE_MODE=alias sudo show interfaces portchannel"
Flags: A - active, I - inactive, Up - up, Dw - Down, N/A - not available,
       S - selected, D - deselected, * - not synced
  No.  Team Dev         Protocol     Ports
-----  ---------------  -----------  ---------------------------
 0001  PortChannel0001  LACP(A)(Up)  Ethernet14/1(S) Ethernet13/1(S)
 0002  PortChannel0002  LACP(A)(Up)  Ethernet16/1(S) Ethernet15/1(S)
 0003  PortChannel0003  LACP(A)(Up)  Ethernet17/1(S) Ethernet18/1(S)
 0004  PortChannel0004  LACP(A)(Up)  Ethernet20/1(S) Ethernet19/1(S)

- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)
N/A

teamshow reads teams raw data by running docker exec -it xxx. However,
the 't' may lead to error when called without a tty. This commit fix the
issue.
@bingwang-ms bingwang-ms merged commit 30bdcb8 into sonic-net:201911 Sep 16, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
Revert "Revert " [201911]show interface counters for multi ASIC devices
(sonic-net#1104)""
 Revert "Revert "Pfcstat (sonic-net#1097)""
  [show] Fix 'show int neighbor expected' (sonic-net#1106)
   Update argument for docker exec it->i (sonic-net#1118)
     Update to make config load/reload backward compatible. (sonic-net#1115)
     Handling deletion of Port Channel before deletion of its members
     (sonic-net#1062)
    Skip default route present in ASIC-DB but not in APP-DB. (sonic-net#1107)
     [CLI][PFCWD][Multi-ASIC] Added multi ASIC support to 'pfcwd' CLI
     (sonic-net#1102)
       [201911]  Multi asic platform config interface portchannel, show
       transceiver  (sonic-net#1087)
       [drop counters] Fix configuration for counters with lowercase
       names (sonic-net#1103)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants