[show] Moving some py imports inside specific show cmds #1031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some py imports are taking more time causing delay in show cmds.
Moved some imports into specific cmds to improve cli exec time.
Signed-off: Sabareesh-Kumar-Anandan [email protected]
- What I did
Some py imports in show/main.py script are taking more time on arm cpus.
modules - pkg_resources, netaddr, portconfig, collections are taking around 800ms causing delay for all show cmds.
These modules are used by only specific cmds. So, I have included these imports only for the commands that are using them.
- How I did it
- How to verify it
Test all show commands. Execution time of show commands is better than before.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)