remove creating IPinIP tunnel for srv6 uN #3797
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Remove the SAI_MY_SID_ENTRY_ENDPOINT_BEHAVIOR_UN condition in mySidTunnelRequired condition checking, do not create IPinIP tunnel for srv6 uN
Why I did it
For the node support srv6 uN only (not support uDT46), it might not implement SAI_TUNNEL_TYPE_IPINIP. creating IPinIP tunnel cause SAI API failed and failed to create SAI_OBJECT_TYPE_MY_SID_ENTRY.
Here is how the function fails in a uN only node:
How I verified it
(will modify current mgmt test)
Details if related