Enable FDB learning event after all ports removed from default 1Q bridge #3630
+15
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR is to fix an orchagent crash issue. Error logs are as below.
It's because FDB is learnt on the default bridge, which increased reference count for bridge port and caused port removal failure.
The issue is addressed by not setting
SAI_SWITCH_ATTR_FDB_EVENT_NOTIFY
when creating switch, and enable it after all ports being removed from default bridge.Why I did it
This PR is to fix an orchagent crash issue.
How I verified it
Broadcom
Mellanox
Cisco
test_fdb.py
can cover the change.Details if related