Improve swssconfig to support ZMQ #3620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Apr 25, 2025
qiluo-msft
reviewed
Apr 25, 2025
swssconfig/swssconfig.cpp
Outdated
| @@ -39,12 +52,36 @@ void dump_db_item(KeyOpFieldsValuesTuple &db_item) | |||
| SWSS_LOG_DEBUG("]"); | |||
| } | |||
|
|
|||
| bool write_db_data(vector<KeyOpFieldsValuesTuple> &db_items) | |||
| bool is_zmq_table(string table_name, int zmq_flag) | |||
There was a problem hiding this comment.
Fixed, add new config in following PR:
sonic-net/sonic-buildimage#22451
qiluo-msft
reviewed
Apr 25, 2025
|
@theasianpianist , @prabhataravind for viz and review. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
commented
Apr 27, 2025
qiluo-msft
reviewed
Apr 27, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
previously approved these changes
Apr 29, 2025
lib/orch_zmq_config.h
Outdated
| * Orchagent ZMQ enabled table will stored in "DEVICE_METADATA|localhost" table "orch_zmq_tables" field. | ||
| */ | ||
| #define DEVICE_METADATA_LOCALHOST "DEVICE_METADATA|localhost" | ||
| #define ZMQ_TABLE_LIST_FIELD "orch_zmq_tables@" |
There was a problem hiding this comment.
Are these 3 #defines used?
There was a problem hiding this comment.
These no longer used, fixed.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
May 1, 2025
theasianpianist
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve swssconfig to support ZMQ
Why I did it
swssconfig does not support ZMQ
How I did it
Improve swss to support ZMQ
swssconfig will load orchagent ZMQ table list from CONFIG_DB, and create ZMQ channel according to the config:
sonic-net/sonic-buildimage#22451
Work item tracking
How to verify it
Pass all test cases.
Verified with PR: sonic-net/sonic-buildimage#22414
Which release branch to backport (provide reason below if selected)
Description for the changelog
Improve swssconfig to support ZMQ
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)