Fixing macsecmgrd memory corruption

[sivanuka]

Fixing macsecmgrd memory corruption

• Macsec port update, results into memory corruption
• Macsec profile replace -> enableMacsec -> disableMacsec[ deletes key in macsec_ports ] -> accessing dangling reference data

Fixes : #3610

What I did
I am allocating memory after deletion of previous profile.
Why I did it
Macsec profile replace -> enableMacsec -> disableMacsec[ deletes key in macsec_ports ] -> accessing dangling reference data -> memory corruption -> crash in macsecmgrd
How I verified it
After this fix, I am not seeing crashes in macsec docker container
Details if related
Valgrind traces are added in #3610

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[sivanuka]

Hi @prsunny,
SA checks are failing at step "install libnl3, sonic swss common and sairedis".
How to resolve it ?
is it due to any change in the PR ?
Thanks !!

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[judyjoseph]

@sivanuka could you share the exact steps you tried to reproduce this issue ? were you using sonic CLI's ? or was it done via sonic_db_cli or other tools ?

[sivanuka]

Hi @judyjoseph,
While running sonic-mgmt macsec tests between( Sonic - cEOS ), we seen macsecmgrd crashing.
sonic-mgmt tests replacing a macsec profile with new profile while running the test https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/macsec/macsec_config_helper.py#L119 ( tests using sonic-db-cli )
We captured the valgrind logs on macsecmgrd process while running macsec sonic-mgmt tests, incorporated in #3610.
Thanks !

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).