[Dynamic Buffer][Mellanox] Fix an issue when handling 2-digit queue ID in the Lua plugin #3588
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
buffer-support-large-queue
branch
from
e6461a3 to
f683d28
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
buffer-support-large-queue
branch
from
f683d28 to
46d14ec
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| # Run lua script and check output | ||
| _, output = dvs.runcmd("redis-cli --eval /usr/share/swss/buffer_pool_vs.lua") | ||
| assert re.search(r"debug:BUFFER_PROFILE_TABLE:egress_test_profile:16384:20", output), "Profile reference count not found in output" |
There was a problem hiding this comment.
Can we also double check ASIC_DB?
There was a problem hiding this comment.
Hi @kperumalbfn
Understanding the mapping between ASIC_DB and APPL DB requires more complicated logic which we do not have in vs.
We have a lot of checks between ASIC/APPL DB in the sonic-mgmt test leveraging existing infra there
So, I don't want to add such logic here.
What do you think?
There was a problem hiding this comment.
Can we use counter_db's QUEUE_NAME_MAP to get the queue OID based on the port+queueIndex and validate with ASIC_DB? This will make sure that profiles are attached to the queues 10-19
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
same issue as that in other PRs. Retrying |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
buffer-support-large-queue
branch
from
46d14ec to
c67135f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@kperumalbfn , is it good to merge? |
stephenxs
force-pushed
the
buffer-support-large-queue
branch
from
c67135f to
bc502cb
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
buffer-support-large-queue
branch
from
bc502cb to
bfdf490
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
force-pushed
the
buffer-support-large-queue
branch
from
bfdf490 to
c47e8fb
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
stephenxs
force-pushed
the
buffer-support-large-queue
branch
from
c47e8fb to
029b0db
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
What I did
Fix an issue when handling 2-digit queue ID in the Lua plugin
Why I did it
Bug fix.
How I verified it
Manual and VS test
Details if related