Skip to content

Move timestamps out of counter table to avoid update too frequently #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Apr 1, 2025

What I did

The timestamp of PFC watchdog polling is moved out of the COUNTER table. The PFC watchdog Lua plugin should be adjusted accordingly.

Why I did it

How I verified it

Details if related

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from d608765 to a14cca5 Compare April 3, 2025 14:11
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from a14cca5 to dbc7a71 Compare April 4, 2025 01:03
@stephenxs stephenxs marked this pull request as ready for review April 4, 2025 01:03
@stephenxs stephenxs requested a review from kperumalbfn as a code owner April 4, 2025 01:03
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator Author

@stephenxs stephenxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kperumalbfn could you please check my reply? Thanks

@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@stephenxs stephenxs requested a review from kperumalbfn April 9, 2025 04:26
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kperumalbfn
Copy link
Contributor

kperumalbfn commented Apr 10, 2025

Thanks @stephenxs Could you link the sairedis PR as well?

@stephenxs
Copy link
Collaborator Author

Thanks @stephenxs Could you link the sairedis PR as well?

Hi @kperumalbfn

sonic-net/sonic-sairedis#1567

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from dbc7a71 to 11e2338 Compare April 11, 2025 08:14
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from 11e2338 to a1b84b2 Compare April 12, 2025 08:16
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from a1b84b2 to 7bcf0a7 Compare April 15, 2025 15:07
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock merge.

@stephenxs stephenxs force-pushed the move-time-stamp-out-of-counter branch from 1cdc289 to fdffcec Compare April 18, 2025 00:32
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-swss.msft#72

@r12f
Copy link

r12f commented Apr 28, 2025

hi @kperumalbfn , do we need this for 202412? looks like a good change to add.

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-swss.msft#75

@kperumalbfn
Copy link
Contributor

hi @kperumalbfn , do we need this for 202412? looks like a good change to add.

@r12f This change will be good for optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants