Skip to content

[Chassis][orchagent] : Support WRED profiles on system ports #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2023
Merged

[Chassis][orchagent] : Support WRED profiles on system ports #2855

merged 5 commits into from
Jul 19, 2023

Conversation

vmittal-msft
Copy link
Contributor

@vmittal-msft vmittal-msft commented Jul 12, 2023 •
edited by gechiang
Loading

MSFT ADO: 24595422

What I did
Added support to apply wred profile on system ports

Why I did it
remote system ports were missing wred profile

How I verified it
Tested on sonic chassis

Details if related

@vmittal-msft vmittal-msft mentioned this pull request Jul 12, 2023
Closed
@vmittal-msft vmittal-msft self-assigned this Jul 12, 2023
@vmittal-msft vmittal-msft changed the title Support WRED profiles on system ports [Chassis][orchagent] : Support WRED profiles on system ports Jul 12, 2023
@gechiang
Copy link
Contributor

@vmittal-msft , please fix test failure

@gechiang
Copy link
Contributor

@vmittal-msft can you fix the test failure?

@vmittal-msft
Copy link
Contributor Author

@gechiang these failures are not related to my changes. I am trying to re-run the build but it is still failing.

@vmittal-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm
arlakshm reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check if we can add UTs

@vmittal-msft vmittal-msft force-pushed the vmittal/wred branch 2 times, most recently from e2c14ea to ae56de2 Compare July 17, 2023 17:58
gechiang
gechiang reviewed Jul 18, 2023
View reviewed changes
arlakshm
arlakshm approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gechiang
Copy link
Contributor

/easycla

@gechiang gechiang merged commit a2a5836 into sonic-net:master Jul 19, 2023
@gechiang
Copy link
Contributor

gechiang commented Jul 19, 2023 •
edited
Loading

MSFT ADO: 24595422

@vmittal-msft vmittal-msft deleted the vmittal/wred branch July 19, 2023 21:31
theasianpianist pushed a commit to theasianpianist/sonic-swss that referenced this pull request Jul 20, 2023
@vmittal-msft @theasianpianist
[Chassis][orchagent] : Support WRED profiles on system ports (sonic-n…
9d1cedc 
…et#2855)

* Support WRED profiles on system ports

* Fix for system port for local ports

* feedback comments

* port up changes

* Fixed feedback comments
@lguohan
Copy link
Contributor

lguohan commented Jul 21, 2023

@gechiang , @vmittal-msft , @prsunny , why lots of code changes, but no single line of unit test added?

@vmittal-msft
Copy link
Contributor Author

@lguohan i will work on the unit case for this change. Sorry for the miss in initial commit.

@gechiang
Copy link
Contributor

@lguohan My bad when I review but missed to check the missing UT check that is required and approved/merged it prematurely.
I have already communicated this with @vmittal-msft and @yxieca that another PR for the missing UT will be made and at that point this PR will then be approved together with the new UT PR to be cherry-picked to other public branch such as 202205.
Sorry for the miss.

@saksarav-nokia
Copy link
Contributor

@vmittal-msft , when will this get merged to 202205?.

@saksarav-nokia saksarav-nokia mentioned this pull request Oct 19, 2023
Closed
@vmittal-msft vmittal-msft mentioned this pull request Oct 26, 2023
Closed
@vmittal-msft vmittal-msft mentioned this pull request Oct 26, 2023
Merged
@saksarav-nokia saksarav-nokia mentioned this pull request Oct 27, 2023
Merged
@vmittal-msft vmittal-msft mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neethajohn neethajohn neethajohn left review comments

@gechiang gechiang gechiang left review comments

@kenneth-arista kenneth-arista kenneth-arista left review comments

@arlakshm arlakshm arlakshm approved these changes

@prsunny prsunny Awaiting requested review from prsunny

Assignees

@vmittal-msft vmittal-msft

Labels
chassis
Projects
SONiC Chassis
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vmittal-msft @gechiang @lguohan @saksarav-nokia @neethajohn @arlakshm @kenneth-arista