[bufferorch] : Support for buffer profiles for VoQ on chassis #2465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
from
9a7e944 to
2dfa43d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
5 times, most recently
from
194dc69 to
347a3ae
Compare
vmittal-msft
commented
Oct 13, 2022
prsunny
reviewed
Oct 13, 2022
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
from
168d0a3 to
5884c9f
Compare
|
This pull request introduces 1 alert and fixes 1 when merging b9edabe into dbdf31c - view on LGTM.com new alerts:
fixed alerts:
|
stephenxs
reviewed
Oct 28, 2022
| return task_process_status::task_invalid_entry; | ||
| } | ||
| if (port.m_queue_lock[ind]) | ||
| std :: vector<sai_object_id_t> queue_ids = gPortsOrch->getPortVoQIds(port); |
There was a problem hiding this comment.
looks like it can be called only once out of the loop.
There was a problem hiding this comment.
Can you please elaborate ? If you are comparing this with regular queue, i am not using port.m_queue_lock[ind] check. Is that a problem ?
Merged
7 tasks
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
2 times, most recently
from
07de488 to
00bbd34
Compare
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
from
00bbd34 to
722c9ba
Compare
prsunny
reviewed
Nov 29, 2022
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
2 times, most recently
from
0603883 to
ab22eba
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
from
34d8649 to
5f895cc
Compare
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
from
b7c156d to
5c455d7
Compare
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2465 in repo sonic-net/sonic-swss |
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
2 times, most recently
from
58d4276 to
60ec2df
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
from
60ec2df to
b8fdb5d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
reviewed
Dec 19, 2022
Updated swss with latest from master temp check in review feedback Commented out test for chassis fix for compilation issue Fixed test failure feedback comments fix for processQ fix for processQ fix for processQ mock test update test_vlan.py fix skipping failing test for virtual chassis disable test_PortAutoNegWarm test minor fix disabling virtual chassis tests for now temp check in unskip failing test unkipped sonic-net#2 test fix minor errors temporarily disable test as PR sonic-net#2541 is having the fix
vmittal-msft
force-pushed
the
vmittal/chassis-voq
branch
from
2466f3d to
0ecbd13
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Dec 20, 2022
8 tasks
yxieca
pushed a commit
that referenced
this pull request
Jan 4, 2023
* QoS changes for VoQ on chassis
|
@vmittal-msft cherry-picking this PR to 202205 branch causes build failure, please raise separate PR. Failure message: |
vmittal-msft
added a commit
to vmittal-msft/sonic-swss
that referenced
this pull request
Jan 12, 2023
…net#2465) * QoS changes for VoQ on chassis
prsunny
pushed a commit
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support for applying QoS profiles on VoQ on chassis
Why I did it
egress_lossy_profile/egress_lossless_profiles were not applied on remote ports on the DUT and were only available for local ports.
How I verified it
Verified that buffer profiles are applied properly on lossy/lossless VoQs on real HW.
Details if related
This PR is dependent on -
#1913
sonic-net/sonic-buildimage#12156
#2467