[macsecorch]: Fix MACsec SC creating before MACsec port enabling #2087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pterosaur
force-pushed
the
fix_macsec_wrong_sequence
branch
from
b9d68c1 to
ca5829f
Compare
Pterosaur
changed the title
Pterosaur
force-pushed
the
fix_macsec_wrong_sequence
branch
2 times, most recently
from
ad00f41 to
5ff63be
Compare
Signed-off-by: Ze Gan <[email protected]>
Pterosaur
force-pushed
the
fix_macsec_wrong_sequence
branch
from
5ff63be to
ed9103d
Compare
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jimmyzhai
approved these changes
Jan 28, 2022
dprital
pushed a commit
to dprital/sonic-swss
that referenced
this pull request
May 8, 2022
…ic-net#2087) * Update MACsec SC attributes after MACsec SC creating Signed-off-by: Ze Gan <[email protected]> * Add unittest Signed-off-by: Ze Gan <[email protected]> * teardown unittest Signed-off-by: Ze Gan <[email protected]> * polish name Signed-off-by: Ze Gan <[email protected]>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
…ic-net#2087) * Update MACsec SC attributes after MACsec SC creating Signed-off-by: Ze Gan <[email protected]> * Add unittest Signed-off-by: Ze Gan <[email protected]> * teardown unittest Signed-off-by: Ze Gan <[email protected]> * polish name Signed-off-by: Ze Gan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ze Gan [email protected]
What I did
Updating MACsec SC configuration on the fly
Why I did it
If the MACsec port configuration comes after MACsec SC creating, the MACsec SC will follow the default configuration. So, Updating MACsec SC configuration on the fly
How I verified it
Azure pipeline status
Details if related
Waiting for sonic-net/sonic-sairedis#986 into master