Enhance getNeighborEntry to return neighbor entry for system neighbor #2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/Azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Apr 21, 2022
|
@abdosi, can you take a look |
|
/Azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
is this one still needed or can be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Enhance getNeighborEntry to return neighbor entry for system neighbor
Why I did it
getNeighborEntry is not able to handle system neighbor today. This breaks features like Everflow in VOQ systems.
How I verified it
We verified the change by testing Everflow in VOQ system (e.g., mirror DIP is resolved to system neighbor).
Details if related