[macsecorch]: Add IPG adjusting for MACsec gearbox model #1925
Conversation
Pterosaur
force-pushed
the
ipg_macsec
branch
2 times, most recently
from
f3359eb to
6697fc2
Compare
Signed-off-by: Ze Gan <[email protected]>
Pterosaur
force-pushed
the
ipg_macsec
branch
from
6697fc2 to
3ce68b2
Compare
Pterosaur
changed the title
Signed-off-by: Ze Gan <[email protected]>
Signed-off-by: Ze Gan <[email protected]>
orchagent/port.h
Outdated
| @@ -28,6 +28,9 @@ extern "C" { | |||
|
|
|||
| #define VNID_NONE 0xFFFFFFFF | |||
|
|
|||
| // Default inter-packet gap(IPG) is 96 which is recommended by IEEE 802.3 | |||
There was a problem hiding this comment.
Recommend adding 'bits' after 96 in comment line just to be explicit, clear
Signed-off-by: Ze Gan <[email protected]>
orchagent/macsecorch.cpp
Outdated
| SAI_MACSEC_DIRECTION_INGRESS); | ||
| }); | ||
|
|
||
| if (phy) | ||
| { | ||
| if (!adjustIPG(port, phy->macsec_ipg)) |
There was a problem hiding this comment.
Is IPG is mandatory parameter? I think it should be optional and every platform may not support this. So I feel you may need check here that if config comes from gerarbox then only adjust if not don't attempt to adjustIPG.
There was a problem hiding this comment.
Make sense, fixed it.
orchagent/macsecorch.cpp
Outdated
| attr.id = SAI_PORT_ATTR_IPG; | ||
| attr.value.u32 = ipg; | ||
|
|
||
| sai_status_t status = sai_port_api->set_port_attribute(port.m_port_id, &attr); |
There was a problem hiding this comment.
Is this SET operation forwarded to NPU or PHY? IPG is configurable property for the port managed by ASIC right?
There was a problem hiding this comment.
IPG configuration will be executed by NPU(Switch ASIC). And it should be a configurable property for the port managed by ASIC.
Signed-off-by: Ze Gan <[email protected]>
Pterosaur
force-pushed
the
ipg_macsec
branch
2 times, most recently
from
0a292ec to
7ac152a
Compare
Signed-off-by: Ze Gan <[email protected]>
|
lack of swss vs test. please add. |
…9202 (sonic-net#1925) * [flex counter] Flex counter threads consume too much CPU resources. #9202 Increase the interval up lmit from 30 seconds to 60 seconds * only modify the interval of watermark counter group * fix merge conflict * fix commit issue
Signed-off-by: Ze Gan [email protected]
What I did
If the MACsec use gearbox model, to adjust the IPG in the system port to the required IPG in the corresponding gearbox at the creating MACsec port stage, and reset the default IPG at the removing MACsec port stage.
Why I did it
Gearbox will increase few bits for MACsec header, if the system port use the default IPG, the gearbox maybe cannot meet the minimum required IPG.
How I verified it
Waiting for a test.
Details if related
Wait for SAI updated to https://github.com/opencomputeproject/SAI/pull/1253/files