Fix failing DPB LAG tests #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Sep 21, 2021
|
|
||
| # 2. Add Ethernet0 to PortChannel0001. | ||
| self.dvs_lag.create_port_channel_member(lag, p.get_name()) |
There was a problem hiding this comment.
this one is a common fixture.. is there an issue with using common function?
There was a problem hiding this comment.
The issue with using the common function is it acts on config_db, which involves flow through teamd and teamd can remove port channel member based on link down and some events.
In the DPB flow this config removal will be handled by teamd and it would generated app_db removal call. But this will come after port remove call which was the issue.
So in test case we should delay the app_db removal and not start again with config_db removal.
|
@zhenggen-xu to review |
prsunny
approved these changes
Sep 23, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
*Fixed the failed DPB LAG tests
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…c-net#1919) #### What I did Change filename per review comments from last PR. Removed print statement from change_applier Added vlan validator & test code for the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed the failed DPB LAG tests
Why I did it
The DPB LAG test was not passing. The test case was meant to cover the race condition scenario where on port removal, port delete arrives at orchagent before lag removal(The dependencies would be removed by breakout command automatically). So port delete should wait until dependencies are removed.
To mimic this, app DB LAG member table should be created first and removed after dpb command. The test was earlier mimicing with cfg DB LAG table (which is not the actual use case). Moreover mimicking config_Db lag table has a race condition where removeLAGMember is called by teamd during link down and thus the flow completes and when actual remove lag member from config_db is called, teamd crashes. This results in further lag remove call to be unhandled leaving residual LAG objects in asic DB failing the tests.
How I verified it
Modifying the tests to operate on top of app DB instead of config DB.
Details if related