[PFC] Fixed the issue that PFC priority on port can't be disabled completely. #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled completely. Signed-off-by: Steven Guo <[email protected]>
|
LGTM pull request analysis was skipped for 3260cdd by steven-guo-ec. Analysis of future commits will happen as normal. |
|
@volodymyrsamotiy could you please help to review? |
|
This change is same as #1962 , so I close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed the issue that the pfc priority is still functioning when disabling the last pfc priority.
Why I did it
The status between SONiC and chip is not consistent when disabling the last pfc priority of a port. After disabling the last pfc priority of a port,
show pfc prioritycommand shows the priority has been disabled, but it still exist in chip. The root cause is that swss treat the configuration of disabling last priority as no change to pfc priority.How I verified it
Verified the status between SONiC and chip became consistent after the modification.
Details if related