[acl]Update acl type check logic #1886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bingwang <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Sep 4, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 7, 2021
Signed-off-by: bingwang <[email protected]>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
Signed-off-by: bingwang <[email protected]>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Remove secrets from dump files.
What I did
Add bash functions to remove secrets from dump files.
How I did it
For tacacs key, radius key, snmp community srring, use sed command with regex to remove user secrets from dump files.
For certs, update tar command exclude list to remove those certs from dump file.
How to verify it
Run 'show techsupport' command and check secrets removed from dump files.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bingwang [email protected]
What I did
This PR is to fix sonic-net/sonic-buildimage#8585
Why I did it
Updating
ACL_TABLE:EVERFLOWandACL_TABLE:EVERFLOWV6separately will cause the EVERFLOW table being recreated rather than being updated.The root cause for this issue is a minor logic error in https://github.com/Azure/sonic-swss/blob/12f0ee7888be5efac5b4213e92d77a030832c40b/orchagent/aclorch.cpp#L3164-L3170
The MIRROR and MIRRORV6 should be treated as the same type on Broadcom platform.
How I verified it
Verified by replacing
orchagentwith the updated one, and updateACL_TABLE|EVERFLOWV6table byredis-cli, and then check syslog.Before this update, the
ACL_TABLE|EVERFLOWtable will be removed andACL_TABLE|EVERFLOWV6will be created.After this update, the
ACL_TABLE|EVERFLOWtable will be updated.Details if related
No.