[201911] Flushing FDB entries per VLAN when deleting VLAN #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liat-grozovik
approved these changes
Dec 31, 2020
|
@madhanmellanox do we need a PR for master as well or this already fixed there? |
liat-grozovik
changed the title
prsunny
approved these changes
Jan 5, 2021
Can you confirm this? |
|
retest this please |
|
This fix is required only in 201911 branch, since the FDB flush implementation is very limited in 201911. In master branch, FdbOrch::updateVlanMember() function is also calling flushFDBEntries(), so we are not seeing this issue in master branch. So, this fix is also not required in master branch. |
|
@prsunny how can we run the LGTM again? or we can merge regardless of the failure? |
4 tasks
abdosi
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jan 7, 2021
Updating submodule for sonic-swss to get the changes to Azure 201911. The following were the commits that were part of this submodule. [201911-SWSS]flushing FDB entries per VLAN when deleting VLAN (PR#sonic-net/sonic-swss#1575) 9519fead3fc63972131de9cb8963a5aeacf7b23d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Flushed FDB entries for specific VLAN when trying to delete the VLAN
Why I did it
As flushing the FDB entries was not done, the VLAN had references in ASIC-DB and could not be removed.
How I verified it
Verified it by creating a VLAN, injecting traffic on the VLAN port and trying to remove the VLAN member port and then removed the VLAN. VLAN removal was successful.
Details if related
Changes were in FDB orchagent and PORTS orchagent of SONIC-SWSS.