Skip to content

[acl] Update CRM to include LAG bindings for ACL tables #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

daall
Copy link
Contributor

@daall daall commented Oct 27, 2020

Signed-off-by: Danny Allen [email protected]

What I did
I updated the AclOrch to correctly report using LAG bindings.

Why I did it
Fixes the issue described here: sonic-net/sonic-utilities#1178

How I verified it
Tested on a DUT locally. THIS STILL NEEDS VS TESTS AS WELL.

Details if related
In draft while I finish the VS tests.

@daall daall marked this pull request as ready for review October 27, 2020 22:44
prsunny
prsunny previously approved these changes Oct 28, 2020
@daall daall requested a review from prsunny October 28, 2020 19:36
@daall daall merged commit 0481e99 into sonic-net:master Oct 29, 2020
@daall daall deleted the acl_crm_update branch October 29, 2020 21:50
@rlhui
Copy link
Contributor

rlhui commented Oct 30, 2020

@prsunny - is this safe for 20191130?

@prsunny
Copy link
Collaborator

prsunny commented Oct 30, 2020

@rlhui , yes it should be.. but not sure if there would be any conflicts.. @daall ?

@daall
Copy link
Contributor Author

daall commented Oct 30, 2020

@rlhui , yes it should be.. but not sure if there would be any conflicts.. @daall ?

There may be a conflict w/ the VS test change, but not 100% sure. If it doesn't cherry-pick cleanly I can open a PR against 201911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants