Fix the ZMQ producer/consumer table does not update changes to the database issue. #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
reviewed
Nov 6, 2024
| p->set(testKey,values); | ||
| delete p; | ||
|
|
||
| sleep(1); |
There was a problem hiding this comment.
Yes, it's stable, 1second is enough
ganglyu
approved these changes
Nov 7, 2024
VladimirKuk
pushed a commit
to Marvell-switching/sonic-swss-common
that referenced
this pull request
Nov 20, 2024
…tabase issue. (sonic-net#942) #### Why I did it Fix a race condition bug: when deleting ZmqProducerStateTable immediately after setting/deleting data, the data is sent to ZMQ but not updated in the database. #### How I did it Verify and wait for the data update before the db update thread exits. ##### Work item tracking #### How to verify it Pass all test cases. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 #### Description for the changelog Fix the ZMQ producer/consumer table does not update changes to the database issue. #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/SONiC/wiki/Configuration. --> #### A picture of a cute animal (not mandatory but encouraged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix a race condition bug: when deleting ZmqProducerStateTable immediately after setting/deleting data, the data is sent to ZMQ but not updated in the database.
How I did it
Verify and wait for the data update before the db update thread exits.
Work item tracking
How to verify it
Pass all test cases.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix the ZMQ producer/consumer table does not update changes to the database issue.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)