Remove the error log form SonicDBConfig::initializeGlobalConfig #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it has already been done
|
@deepak-singhal0408 @mlok-nokia Please help to review. |
|
MSFT ADO: 25516271 |
|
@deepak-singhal0408 Thanks for review. Can you help to merge the changes? I don't have permission to do that. Thanks. |
|
Hi @qiluo-msft, could you please help review this PR? Thanks! |
qiluo-msft
reviewed
Apr 8, 2024
| @@ -84,7 +84,6 @@ void SonicDBConfig::initializeGlobalConfig(const string &file) | |||
|
|
|||
| if (m_global_init) | |||
| { | |||
| SWSS_LOG_ERROR("SonicDBConfig Global config is already initialized"); | |||
qiluo-msft
requested changes
Apr 8, 2024
|
Hi @wumiaont , please have a look at this PR.. sonic-net/sonic-buildimage#10960.. |
|
The issue does not happen on master. Have a fix for 202205. Please review that one. sonic-net/sonic-buildimage#18609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: If run "show interfaces status" we often see the error in syslog "SonicDBConfig Global config is already initialized".
Analysis: During investigation it is found the swsscommon.load_sonic_global_db_config() has been triggered multiple times. Espically in a multi Asic scenario.
CLI triggers "intfutil -c status" with a separate process. Within the process it will trigger IntfStatus init --> MultiAsic() init-->load_db_config()-->load_sonic_global_db_config(). This time initializeGlobalConfig() will run to the end as m_global_init flag is false.
CLI will also run get_port_config() --> db_connect_configdb() --> load_sonic_global_db_config() (for different namepaces. In our case is asic0 and asic1). This time m_global_init flag is true which causes error log and return.
Conclusion: After researching we found load_db_config() could be called by different Classes. The code has already added protection to avoid to initialize global config multiple time. The error log is not necessary to be there.
Solution: Removed the error log from initializeGlobalConfig() when found global config is already initialized.