Skip to content

swss-common: WRED and ECN statistics specific changes #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023

Conversation

rpmarvell
Copy link
Contributor

@rpmarvell rpmarvell commented Apr 24, 2023

  • Flexcounter macros are defined
  • Statistics capability get lua script updated with new Capability API support

Details :

The Build is failing in this review because of the earlier PR committed to branch not having respective testcase fixed.

Expected order of dependent pull-request to be committed :

  1. sonic-swss common pull request : swss-common: WRED and ECN statistics specific changes #777
  2. sonic-sairedis pull request : sonic-sairedis : Wred stats feature changes on Sai-redis and Syncd sonic-sairedis#1234
  3. sonic-swss : pull request : sonic-swss: Code changes for WRED and ECN statistics sonic-swss#2750
  4. sonic-yang-model pull requests : sonic-yang-models: WRED statistics yang sonic-buildimage#14758
  5. sonic-utilities pull request : sonic-utilities: WRED stats feature changes on sonic-utilities sonic-utilities#2807

* Flexcounter macros are defined
* Statistics capability get lua script updated with new Capability API support

Signed-off-by: rpmarvell <[email protected]>
@msosyak
Copy link

msosyak commented May 8, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 19, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 19, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 21, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 24, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 24, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 24, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 25, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 26, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 26, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 26, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak
Copy link

msosyak commented May 27, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor

liuh-80 commented May 30, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@msosyak msosyak merged commit e266a97 into sonic-net:master May 31, 2023
SviatoslavBoichuk pushed a commit to SviatoslavBoichuk/sonic-swss-common that referenced this pull request Sep 7, 2023
* Flexcounter macros are defined
* Statistics capability get lua script updated with new Capability API support

Signed-off-by: rpmarvell <[email protected]>
prsunny pushed a commit to sonic-net/sonic-swss that referenced this pull request Feb 18, 2025
*sonic-swss: Code changes for WRED and ECN statistics (#2750)

New flex counter group for per-Queue WRED and ECN statistics
New flex counter group for per-Port WRED and ECN statistics

Why I did it
Implemented as per the HLD : https://github.com/sonic-net/SONiC/blob/master/doc/qos/ECN_and_WRED_statistics_HLD.md

How I verified it
Verfied it using Marvell DUT and SWSS unit tests.

Details if related

Two new flex counters added for per-Queue and per-Port WRED ECN statistics.
Build dependency on sonic-swss-common pull request : sonic-net/sonic-swss-common#777
r12f pushed a commit to r12f/sonic-swss.msft that referenced this pull request Feb 28, 2025
*sonic-swss: Code changes for WRED and ECN statistics (#2750)

New flex counter group for per-Queue WRED and ECN statistics
New flex counter group for per-Port WRED and ECN statistics

Why I did it
Implemented as per the HLD : https://github.com/sonic-net/SONiC/blob/master/doc/qos/ECN_and_WRED_statistics_HLD.md

How I verified it
Verfied it using Marvell DUT and SWSS unit tests.

Details if related

Two new flex counters added for per-Queue and per-Port WRED ECN statistics.
Build dependency on sonic-swss-common pull request : sonic-net/sonic-swss-common#777
mssonicbld added a commit to mssonicbld/sonic-swss.msft that referenced this pull request Feb 28, 2025
* New flex counter group for per-Queue WRED and ECN statistics
* New flex counter group for per-Port WRED and ECN statistics

  Signed-off-by: [email protected]

<!--
Please make sure you have read and understood the contribution guildlines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

1. Make sure your commit includes a signature generted with `git commit -s`
2. Make sure your commit title follows the correct format: [component]: description
3. Make sure your commit message contains enough details about the change and related tests
4. Make sure your pull request adds related reviewers, asignees, labels

Please also provide the following information in this pull request:
-->

**What I did**
WRED and ECN statistics support

**Why I did it**
Implemented as per the HLD : https://github.com/sonic-net/SONiC/blob/master/doc/qos/ECN_and_WRED_statistics_HLD.md

**How I verified it**
Verfied it using Marvell DUT and SWSS unit tests.

**Details if related**
- Two new flex counters added for per-Queue and per-Port WRED ECN statistics.

Build dependency on sonic-swss-common pull request : sonic-net/sonic-swss-common#777

Expected order of dependent pull-request to be committed :
1) sonic-swss common pull request : sonic-net/sonic-swss-common#777
2) sonic-yang-model pull requests : sonic-net/sonic-buildimage#14758
3) sonic-sairedis pull request : sonic-net/sonic-sairedis#1234
4) sonic-swss : pull request : sonic-net/sonic-swss#2750
5) sonic-utilities pull request : sonic-net/sonic-utilities#2807
mssonicbld added a commit to Azure/sonic-swss.msft that referenced this pull request Feb 28, 2025
* New flex counter group for per-Queue WRED and ECN statistics
* New flex counter group for per-Port WRED and ECN statistics

 Signed-off-by: [email protected]

<!--
Please make sure you have read and understood the contribution guildlines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

1. Make sure your commit includes a signature generted with `git commit -s`
2. Make sure your commit title follows the correct format: [component]: description
3. Make sure your commit message contains enough details about the change and related tests
4. Make sure your pull request adds related reviewers, asignees, labels

Please also provide the following information in this pull request:
-->

**What I did**
WRED and ECN statistics support

**Why I did it**
Implemented as per the HLD : https://github.com/sonic-net/SONiC/blob/master/doc/qos/ECN_and_WRED_statistics_HLD.md

**How I verified it**
Verfied it using Marvell DUT and SWSS unit tests.

**Details if related**
- Two new flex counters added for per-Queue and per-Port WRED ECN statistics.

Build dependency on sonic-swss-common pull request : sonic-net/sonic-swss-common#777

Expected order of dependent pull-request to be committed :
1) sonic-swss common pull request : sonic-net/sonic-swss-common#777
2) sonic-yang-model pull requests : sonic-net/sonic-buildimage#14758
3) sonic-sairedis pull request : sonic-net/sonic-sairedis#1234
4) sonic-swss : pull request : sonic-net/sonic-swss#2750
5) sonic-utilities pull request : sonic-net/sonic-utilities#2807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants