Improve hset and hdel performance with RedisPipeline. #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR just check-in test code, according to discussion result, if we decide to have this improve, we also need improve hdel and remove the lua script. |
liuh-80
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
changed the title
added 2 commits
July 13, 2022 07:07
liuh-80
changed the title
liuh-80
requested review from
kcudnik and
qiluo-msft
and removed request for
kcudnik
liuh-80
commented
Jul 13, 2022
| const std::vector<FieldValueTuple> &values); | ||
|
|
||
| template<typename InputIterator> | ||
| void formatHMSET(const std::string &key, |
There was a problem hiding this comment.
formatHMSET is internal API, only use by sonic-swss-common project;
https://github.com/search?q=org%3AAzure+formatHMSET&type=code
liuh-80
commented
Jul 13, 2022
7 tasks
This comment was marked as resolved.
This comment was marked as resolved.
qiluo-msft
previously approved these changes
Jul 13, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
changed the title
liuh-80
changed the title
qiluo-msft
reviewed
Jul 15, 2022
qiluo-msft
reviewed
Jul 15, 2022
common/redispipeline.h
Outdated
| @@ -61,6 +62,26 @@ class RedisPipeline { | |||
| return r.release(); | |||
| } | |||
|
|
|||
| redisReply *pushHSET(const std::string& key, const std::map<std::string, std::string> &values) | |||
There was a problem hiding this comment.
Fixed, moved to RedisCommand class.
liuh-80
commented
Jul 15, 2022
| @@ -1,6 +1,7 @@ | |||
| #pragma once | |||
|
|
|||
| #include <string> | |||
| #include <queue> | |||
There was a problem hiding this comment.
RedisPipeline using std::queue but not include the header file.
So some time when include this header file will report build error.
qiluo-msft
approved these changes
Jul 15, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
itamar-talmon
pushed a commit
to itamar-talmon/sonic-swss-common
that referenced
this pull request
Jul 19, 2022
#### Why I did it 1.Change redis hmset command to hset because HMSET deprecated after redis 4.0.0: https://redis.io/commands/hmset/ 2.Improve DBConnector::hmset and DBConnector::del method performance. Currently swsscommon implement hmset and del by LUA script, however change to use RedisPipeline can improve performance by 20%: RedisPipeline hmset: 0.228743 LUA hmset: 0.260371 #### How I did it Change hmset and del to use RedisPipeline. #### How to verify it Pass all test case. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 #### Description for the changelog #### Link to config_db schema for YANG module changes #### A picture of a cute animal (not mandatory but encouraged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
1.Change redis hmset command to hset because HMSET deprecated after redis 4.0.0:
https://redis.io/commands/hmset/
2.Improve DBConnector::hmset and DBConnector::del method performance.
Currently swsscommon implement hmset and del by LUA script, however change to use RedisPipeline can improve performance by 20%:
RedisPipeline hmset: 0.228743
LUA hmset: 0.260371
How I did it
Change hmset and del to use RedisPipeline.
How to verify it
Pass all test case.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)