Install sonic-buildimage libnl3 for AZP #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prsunny @smaheshm Please review as sonic-net/sonic-swss#1871 is merged to master and sonic-swss-common AZP will need this PR once sonic-swss submodule is updated in sonic-buildimage. |
smaheshm
reviewed
Aug 27, 2021
|
@prsunny @smaheshm I see that sonic-swss-common AZP is already failing due to merged changes from sonic-net/sonic-swss#1871. Please approve/merge this PR to resolve the AZP failure. |
kcudnik
reviewed
Aug 27, 2021
Comment on lines
+77
to
+84
| sudo dpkg -i target/debs/buster/libnl-3-200_*.deb | ||
| sudo dpkg -i target/debs/buster/libnl-3-dev_*.deb | ||
| sudo dpkg -i target/debs/buster/libnl-genl-3-200_*.deb | ||
| sudo dpkg -i target/debs/buster/libnl-genl-3-dev_*.deb | ||
| sudo dpkg -i target/debs/buster/libnl-route-3-200_*.deb | ||
| sudo dpkg -i target/debs/buster/libnl-route-3-dev_*.deb | ||
| sudo dpkg -i target/debs/buster/libnl-nf-3-200_*.deb | ||
| sudo dpkg -i target/debs/buster/libnl-nf-3-dev_*.deb |
There was a problem hiding this comment.
sudo dpkg -i target/debs/buster/libnl-*.deb ?
There was a problem hiding this comment.
Current change avoids unneeded installation of libnl-cli-3-200 and libnl-cli-3-dev.
smaheshm
approved these changes
Aug 27, 2021
|
I'm s tarring to erring errors with libnl on swss compile: is this related? |
yes it is. That's why this needs to be merge ASAP |
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
…s no error (sonic-net#518) - Description The "get_error_description" function should return 'OK' instead of 'None' when there are no errors. - Motivation and Context When there are no errors on the cable, get_error_description currently returns 'None'. In this case, we should return 'OK' so that the CLI (show interface transceiver error-description) provides a proper output. - How Has This Been Tested? Call this API directly on different cables with different error statuses. Signed-off-by: Kebo Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
AZP changes to install libnl3 from sonic-buildimage
Why I did it
Prevent sonic-swss-common AZP build failures in docker-sonic-vs.
fpmsyncd in sonic-swss now relies on modified version of libnl3 in sonic-buildimage with additional support for MPLS.
Any AZP build of docker-sonic-vs must now install libnl3 from sonic-buildimage build artifact rather than Debian released version of libnl3.
How I verified it
Unit-tests in sonic-swss/tests/test_mpls.py
System tests in sonic-mgmt
Details if related
Refer to PR: sonic-net/sonic-swss#1871