Skip to content

Move warm_restart enable/disable config to stateDB WARM_RESTART_ENABL… #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

jipanyang
Copy link
Contributor

@jipanyang jipanyang commented Feb 7, 2019

…E_TABLE

Signed-off-by: Jipan Yang [email protected]

For warm_restart enable/disable configuration, putting them into configDB caused confusion in configuration save and restore. They are not supposed to be persistent across cold boot. Moving them to stateDB which will be saved and restored during warm reboot.

#260

sonic-net/sonic-swss#786

sonic-net/sonic-sairedis#418

sonic-net/sonic-utilities#458

sonic-net/sonic-buildimage#2538

Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused table. Otherwise looks good to me.

Never mind, the config table is still used for timeouts.

@yxieca yxieca merged commit 414de0f into sonic-net:master Feb 12, 2019
yxieca pushed a commit that referenced this pull request Feb 14, 2019
@yxieca
Copy link
Contributor

yxieca commented Feb 14, 2019

Made to 201811 branch on 2/14/2019

prgeor pushed a commit to prgeor/sonic-swss-common that referenced this pull request Feb 27, 2025
…t#260)

Signed-off-by: vaibhav-dahiya [email protected]

Description
Currently is_link_active API was broken because it was not using the target param in the routine to give back the correct link_status of ecah side. With this change it gives the correct result.

Motivation and Context
Required for MUX_CABLE_INFO table in streaming telemetry if the cable is disconnected or the link is down.

redis-cli -n 6 hgetall "MUX_CABLE_INFO|Ethernet16"
"
 9) "link_status_self"
10) "down"
11) "link_status_peer"
12) "up"
13) "link_status_nic"
14) "up"
How Has This Been Tested?
Tested on actual Arista7050cx3 testbed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants