[rfc2737] Fix issue: expect redis pubsub data to be str type instead of bytes type #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft can you please take a look? |
qiluo-msft
reviewed
Feb 16, 2021
| @@ -675,7 +675,7 @@ def _update_per_namespace_data(self, pubsub): | |||
|
|
|||
| db_entry = msg["channel"].split(":")[-1] | |||
| data = msg['data'] # event data | |||
| if not isinstance(data, bytes): | |||
| if not isinstance(data, str): | |||
There was a problem hiding this comment.
str [](start = 36, length = 3)
This seems a valid fix. Wondering how it worked before? I think it hit a type runtime error below "set" in data ?
There was a problem hiding this comment.
it was b"set" before.
qiluo-msft
approved these changes
Feb 18, 2021
|
@qiluo-msft can we merge and set label to 202012 |
This was referenced Feb 23, 2021
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Feb 23, 2021
183162f Fix issue: expect redis pubsub data to be str type instead of bytes type (#196) #### Why I did it Update submodule pointer for snmpagent to include PR sonic-net/sonic-snmpagent#196 #### How I did it Update submodule pointer for snmpagent #### How to verify it Run build
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
183162f Fix issue: expect redis pubsub data to be str type instead of bytes type (sonic-net#196) #### Why I did it Update submodule pointer for snmpagent to include PR sonic-net/sonic-snmpagent#196 #### How I did it Update submodule pointer for snmpagent #### How to verify it Run build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Change redis pubsub expect data type from bytes to str. There was a snmpagent framework change which transfer redis pubsub data from bytes to str, after that change, there is no need for non-framework code to do this transfer. So now we need handle str data directly.
- How I did it
Change data expectation from bytes to str
- How to verify it
Run regression and manual test
- Description for the changelog