Skip to content

Change the log severity level from ERROR to NOTICE if getStatus is not supported by vendor (cherry-pick #908) #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

stephenxs
Copy link
Contributor

Change the log severity level from ERROR to NOTICE if getStatus is not supported by vendor
This is to cherry-pick #908 to 202106.

Signed-off-by: Stephen Sun [email protected]

@stephenxs
Copy link
Contributor Author

Failed by swss compiling error

g++ -DHAVE_CONFIG_H -I. -I.. -I .. -I ../warmrestart -I  -g  -std=c++14 -Wall -fPIC -Wno-write-strings -I/usr/include/swss -I/usr/include/libnl3 -Werror -Wno-reorder -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Winvalid-pch -Wlong-long -Wmissing-field-initializers -Wmissing-format-attribute -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wno-switch-default -Wno-long-long -Wno-redundant-decls -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/__w/1/s=. -fstack-protector-strong -Wformat -Werror=format-security -c -o fpmsyncd-warmRestartHelper.o `test -f '../warmrestart/warmRestartHelper.cpp' || echo './'`../warmrestart/warmRestartHelper.cpp
routesync.cpp: In member function 'void swss::RouteSync::getNextHopList(rtnl_route*, std::__cxx11::string&, std::__cxx11::string&, std::__cxx11::string&)':
routesync.cpp:1040:25: error: 'rtnl_route_nh_get_encap_mpls_dst' was not declared in this scope
             if ((addr = rtnl_route_nh_get_encap_mpls_dst(nexthop)))
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
routesync.cpp:1040:25: note: suggested alternative: 'rtnl_route_nh_encap_mpls'
             if ((addr = rtnl_route_nh_get_encap_mpls_dst(nexthop)))
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         rtnl_route_nh_encap_mpls
make[3]: *** [Makefile:472: fpmsyncd-routesync.o] Error 1

@kcudnik can you help retrigger the building? thanks

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 921 in repo Azure/sonic-sairedis

@kcudnik
Copy link
Collaborator

kcudnik commented Sep 9, 2021

not sure if this will compile since recently on master libnl was updated, not sure if this is already propagated to 202106, and since we se error then it;s not propagated, check this out:
#877 and changed files i think this also happened on swss repo too

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 921 in repo Azure/sonic-sairedis

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 1, 2021

there is som issue with azp for BuildSwss amd64, i can;t restart the build it says is gone, maybe it took to long but it should be ok, since this is just logging change, and other builg passed, but if you want to be sure you can retrigger this by pushing some dummy commit or force pushing

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 921 in repo Azure/sonic-sairedis

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 18, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 921 in repo Azure/sonic-sairedis

@kcudnik
Copy link
Collaborator

kcudnik commented Nov 16, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-sairedis

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 921 in repo Azure/sonic-sairedis

@kcudnik
Copy link
Collaborator

kcudnik commented Nov 24, 2021

/azp run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-sairedis

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 921 in repo Azure/sonic-sairedis

@liat-grozovik
Copy link
Collaborator

/azpw run Azure.sonic-sairedis

@kcudnik
Copy link
Collaborator

kcudnik commented Dec 6, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator

kcudnik commented Dec 6, 2021

if this time build fails i'm merging this anyway, since error not related to PR

@liat-grozovik
Copy link
Collaborator

@kcudnik could you please merge?

@kcudnik kcudnik merged commit de02b6d into sonic-net:202106 Dec 7, 2021
@stephenxs stephenxs deleted the change-log-severity branch December 7, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants