Skip to content

Code clean #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Code clean #721

merged 1 commit into from
Dec 5, 2020

Conversation

kcudnik
Copy link
Collaborator

@kcudnik kcudnik commented Nov 29, 2020

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2020

This pull request fixes 1 alert when merging f01eab3 into f26c408 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

@kcudnik kcudnik requested review from abdosi, daall and jleveque December 3, 2020 14:16
@@ -829,7 +829,7 @@ void AsicView::asicRemoveObject(
break;

case SAI_OBJECT_TYPE_NAT_ENTRY:
m_soNatEntries[currentObj->m_str_object_id] = currentObj;
m_soNatEntries.erase(currentObj->m_str_object_id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a bug?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kcudnik kcudnik merged commit 620d7a4 into sonic-net:master Dec 5, 2020
@kcudnik kcudnik deleted the cc branch December 5, 2020 11:30
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants