Skip to content

Support auto negotiation on the VS platform to avoid error messages. #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

stephenxs
Copy link
Contributor

@stephenxs stephenxs commented Mar 10, 2025

Support auto negotiation on the VS platform to avoid error messages.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@stephenxs stephenxs changed the title Support auto negotiation Support auto negotiation on VS platform Mar 10, 2025
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs marked this pull request as ready for review March 17, 2025 01:59
@stephenxs stephenxs changed the title Support auto negotiation on VS platform Support auto negotiation on the VS platform to avoid error messages. Mar 17, 2025
@stephenxs stephenxs requested a review from kcudnik March 17, 2025 02:52
Signed-off-by: Stephen Sun <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Contributor Author

Hi @kcudnik
could you help merge this pr?
thanks

@r12f
Copy link
Contributor

r12f commented Apr 19, 2025

hi @stephenxs , do you mind to help with manual cherry pick to 202412 branch?

@r12f
Copy link
Contributor

r12f commented Apr 28, 2025

hi @stephenxs , just checking, is this PR manual picked into 202412?

@r12f
Copy link
Contributor

r12f commented May 1, 2025

hi @stephenxs , gently ping again.

@stephenxs
Copy link
Contributor Author

Hi @r12f
yes, based on the lastest 202412

commit 4508a2359d97a30ab4aab865a9ea728bc99786fd (HEAD)
Author: Stephen Sun <[email protected]>
Date:   Tue Mar 18 21:02:36 2025 +0900

    Support auto negotiation (#1549)
    
    Support auto negotiation on the VS platform to avoid error messages.
    
    Signed-off-by: Stephen Sun <[email protected]>

commit 0209ab89769f7c6dd53d3a15242f5ae49d189591 (msft/HEAD, msft/202412)
Author: mssonicbld <[email protected]>
Date:   Mon Apr 28 13:01:57 2025 +0800

    [FlexCounter] add support for SRv6 MySID counters (#50)
    
    * Add support for a new SRv6 MySID counter
    * Extended flex counter test

@stephenxs
Copy link
Contributor Author

hi @r12f
would you approve cherry-pick? no conflict :)

@r12f
Copy link
Contributor

r12f commented May 1, 2025

Woot! Nice!

@r12f
Copy link
Contributor

r12f commented May 1, 2025

Thanks a lot!

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-sairedis.msft#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants