Skip to content

[xcvrd] Optimize module initialization performance #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Junchao-Mellanox
Copy link
Collaborator

Description

  1. Use hget instead of hgetall to gain better performance
  2. Optimize SfpStateUpdateTask.init:
  • Use cache in this function for different logical ports with the same physical module.
  • Handles transceiver info table and media settings before any other table.

Motivation and Context

Improve module initialization performance

How Has This Been Tested?

Manual test

Additional Information (Optional)

@mssonicbld
Copy link
Collaborator

/azp run

@Junchao-Mellanox Junchao-Mellanox marked this pull request as draft May 8, 2025 02:59
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox force-pushed the master-xcvrd-optimize branch from d4413b7 to 474a0e7 Compare May 9, 2025 07:08
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox requested review from mihirpat1, prgeor and keboliu and removed request for mihirpat1 May 9, 2025 10:11
@Junchao-Mellanox Junchao-Mellanox force-pushed the master-xcvrd-optimize branch from 99bcda1 to d99a906 Compare May 9, 2025 10:19
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review May 9, 2025 10:26
@liat-grozovik
Copy link
Collaborator

@mihirpat1 @prgeor kindly hep to review and comment on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants