Refactor port_port_sfp_info_to_db() to read key:value pairs directly from port_info_dict #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from port_info_dict
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
approved these changes
Feb 21, 2025
|
@mihirpat1 can you review |
mihirpat1
approved these changes
Feb 25, 2025
|
Cherry-pick PR to msft-202412: Azure/sonic-platform-daemons.msft#9 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For CMIS specific transceivers, read the key:value pairs directly from port_info_dict
Motivation and Context
Reduces duplication of the code and make it future ready for any new key:value pairs.
How Has This Been Tested?
Verified 'show interfaces transceiver info' and 'sfputil show eeprom -p' outputs on an Arista testbed.
Additional Information (Optional)