[Mellanox] Fix thermal control bugs #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Junchao-Mellanox
commented
Mar 11, 2020
Junchao-Mellanox
commented
- Catch exception in every fan/thermal refresh loop to avoid exit loop too early
- For absense fan, no need get its data from platform API
- Add unit test for new code
jleveque
approved these changes
Mar 17, 2020
|
Request for 201911 with sonic-net/sonic-buildimage#3949 @jleveque @abdosi |
wendani
reviewed
Apr 21, 2020
| except Exception as e: | ||
| logger.log_warning('Failed to update thermal status - {}'.format(e)) | ||
| except Exception as e: | ||
| logger.log_warning('Failed to update thermal status - {}'.format(e)) | ||
|
|
||
| logger.log_debug("End temperature updating") |
There was a problem hiding this comment.
Can you remove debugging log, which shows up every 60s in syslog
DEBUG pmon#thermalctld: Start temperature updating
DEBUG pmon#thermalctld: End temperature updating
There was a problem hiding this comment.
Sure, will remove it in another PR.
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
Signed-off-by: Andriy Kokhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.