Skip to content

CMIS 'ConfigSuccess" failure while changing default ApSel code for 800G DR8/FR8 modules #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 17, 2024
Merged

CMIS 'ConfigSuccess" failure while changing default ApSel code for 800G DR8/FR8 modules #459

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2a78cf7
Update xcvrd.py
AnoopKamath Apr 5, 2024
64bbd53
update reset_app_code mock test
AnoopKamath May 14, 2024
48ab108
Update mock test for reset_app_code
AnoopKamath May 14, 2024
ca78496
Add new api to reset app code
AnoopKamath May 14, 2024
9aa9ca5
Fix build failures and add return type
AnoopKamath May 14, 2024
c6ed502
Rename apis
AnoopKamath May 15, 2024
d6d66a2
Address review comments
AnoopKamath May 15, 2024
830535e
Merge branch 'sonic-net:master' into master
AnoopKamath May 16, 2024
3d7dda6
remove decommission api from xcvrd
AnoopKamath May 16, 2024
e02ab08
Update xcvrd.py
AnoopKamath May 16, 2024
82a4de4
Update test_xcvrd.py
AnoopKamath May 16, 2024
2fb6f92
Update test_xcvrd.py
AnoopKamath May 16, 2024
674945f
Update test_xcvrd.py
AnoopKamath May 17, 2024
b6cbcf6
Update test_xcvrd.py
AnoopKamath May 17, 2024
a6254f5
Add mock test to capture fail case
AnoopKamath May 17, 2024
d78712d
Address review comments
AnoopKamath May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions sonic-xcvrd/xcvrd/xcvrd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,12 +1000,22 @@ def is_cmis_application_update_required(self, api, app_new, host_lanes_mask):
for lane in range(self.CMIS_MAX_HOST_LANES):
if ((1 << lane) & host_lanes_mask) == 0:
continue
app_cur = api.get_application(lane)
if app_old == 0:
app_old = api.get_application(lane)
elif app_old != api.get_application(lane):
app_old = app_cur
elif app_cur != 0:
if app_cur != app_new:
self.log_notice("Changing from default AppSel {} to non default "
"AppSel code {}. Reset AppSel code for all lanes"
.format(app_cur, app_new))
api.set_application(0xff, 0, 0)
api.set_datapath_deinit(0xff)
api.scs_apply_datapath_init(0xff)
return True
elif app_old != app_cur:
self.log_notice("Not all the lanes are in the same application mode "
"app_old {} current app {} lane {} host_lanes_mask {}".format(
app_old, api.get_application(lane), lane, host_lanes_mask))
app_old, app_cur, lane, host_lanes_mask))
self.log_notice("Forcing application update...")
return True

Expand Down
Loading