Support to get MEDIA_SETTING and OPTICS_SI from both platform folder and HWSKU folder #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kebo Liu <[email protected]>
keboliu
force-pushed
the
master_media_optics_setting
branch
from
7454f8c to
90a1af6
Compare
|
@keboliu Pleas specify the other dependent PR in the description. |
Junchao-Mellanox
approved these changes
Apr 2, 2024
done. |
mihirpat1
approved these changes
Apr 2, 2024
prgeor
previously approved these changes
Apr 9, 2024
|
@keboliu please fix the build failure |
Signed-off-by: Kebo Liu <[email protected]>
fixed, would you please approve again? |
|
@prgeor would you please review and merge? |
|
@prgeor can we go a head and merge? |
prgeor
approved these changes
Apr 17, 2024
|
@liat-grozovik @keboliu there is cherry pick conflict for 202311. please raise separate PR for 202311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support to get the media_settings.json and optics_si_settings.json files from both the platform folder and the SKU folder.
It will search the HWSKU folder first and then fall back to the platform folder.
combine with PR sonic-net/sonic-buildimage#18441, the vendor will be able to enable CMIS cable host mgmt. function per SKU(choose to put the specific pmon_daemon_control.json, media_settings.json and optics_si_settings.json to the SKU folder).
Motivation and Context
The vendor will have the flexibility to have both files in the platform scope or the SKU scope.
How Has This Been Tested?
Build image, manually test,
Additional Information (Optional)