Dynamic transceiver tuning support #26
Conversation
UT fixes UT fixes Addressing code review comments Addressing review comments Adding media key values in global section Adding media key values in port section Fixing for SR4 case
dgsudharsan
changed the title
sonic-xcvrd/scripts/xcvrd
Outdated
| # Connect to ASIC_DB to notify Media notifications | ||
| asic_db = daemon_base.db_connect(swsscommon.ASIC_DB) | ||
| media_notifier = swsscommon.NotificationProducer(asic_db, | ||
| "MEDIANOTIFICATION") |
There was a problem hiding this comment.
There is a corner case that user might insert a SFP during warmboot, In such case that function post_port_sfp_dom_info_to_db seems will skip programming serdes tuning value to asic and will never be programmed for this newly plugged SFP until OIR again.
Could you consider such case even is a very rare case?
Hi @stevenlu99 Yes I think that event will be very rare case and is it worth to handle such a case? I am not sure if someone might do a warm reboot and in parallel change cabling (It defeats the purpose of warm reboot) |
Support for multiple ranges Added logic to have default values at global level incase multiple ports have same defaults
- What I did
Dynamic transceiver tuning support
- How I did it
Dynamically program pre-emphasis and other settings based on media detected in xcvrd. The various supported media are defined in media_settings.json
- How to verify it
Perform OIR of different media types. Dump the pre-emphasis values from hardware and verify that they got reflected
- Description for the changelog
Support for dynamically programming pre-emphasis
- A picture of a cute animal (not mandatory but encouraged)