Remove redundancy in ledd #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation of front-panel LED controls has a lot of redundancies that are unnecessary for what it currently does. It would always set all front-panel LEDs to off, populate a dictionary, then iterate through the dictionary to turn LEDs to correct colors. LEDs can simply be set through one iteration.
jleveque
approved these changes
Feb 26, 2018
praveen-li
pushed a commit
to praveen-li/sonic-platform-daemons
that referenced
this pull request
May 3, 2021
* msft_github/master: Remove redundancy in ledd (sonic-net#12)
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
Signed-off-by: Guohan Lu <[email protected]>
vvolam
pushed a commit
to vvolam/sonic-platform-daemons
that referenced
this pull request
Jun 16, 2025
…noff_202412 [xcvrd] Add wait based on MaxDurationDPTxTurnOff after disabling Tx sonic-net#602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sonic-ledd/scripts/ledd: Remove redundacies
Previous implementation of front-panel LED controls has a lot of
redundancies that are unnecessary for what it currently does. It would
always set all front-panel LEDs to off, populate a dictionary, then
iterate through the dictionary to turn LEDs to correct colors. LEDs can
simply be set through one iteration.
In normal SONiC it was already noticeable (LEDs flash off for a brief
moment every second) but for SONiC+cEOS it is much worse since
turning on or off LEDs takes a much longer amount of time.
This problem was found by internal product tests testing SONiC+cEOS.
Signed-off-by: Zhi Yuan Zhao [email protected]