SFP(sff8472 attributes) transciever eeprom attribute support. #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lguohan
approved these changes
Mar 20, 2020
abdosi
pushed a commit
that referenced
this pull request
Apr 19, 2020
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…nic-net#74) As part of consolidating all common Python-based functionality into the new sonic-py-common package, this pull request migrates from importing the sonic-daemon-base package to importing the sonic-py-common package. This is the next step toward resolving sonic-net/sonic-buildimage#4999. - Also reorganize imports for consistency
Junchao-Mellanox
pushed a commit
to Junchao-Mellanox/sonic-platform-common
that referenced
this pull request
May 7, 2025
…eivers (sonic-net#74) <!-- Provide a general summary of your changes in the Title above --> #### Description This PR introduces **RX disable support** for CMIS-compliant transceivers, aligning it with TX disable functionality. <!-- Describe your changes in detail This PR introduces **RX disable support** for CMIS-compliant transceivers, aligning it with TX disable functionality. --> #### Motivation and Context - Added the following methods in `CmisApi` and `XcvrApi`: - `get_rx_disable()` - `get_rx_disable_channel()` - `rx_disable()` - `rx_disable_channel()` - Updated `SfpOptoeBase` to expose RX disable functionality. <!-- Why is this change required? What problem does it solve? If this pull request closes/resolves an open Issue, make sure you include the text "fixes #xxxx", "closes #xxxx" or "resolves #xxxx" here --> - Defined `RX_DISABLE_SUPPORT_FIELD` in `consts.py`. - Added `RX_DISABLE_FIELD` at **Byte 138** in `CmisMemMap`. - Updated `CTRLS_ADVT_FIELD` to include `RX_DISABLE_SUPPORT_FIELD`. - Integrated RX disable methods into `sfp_optoe_base.py`, mirroring TX disable operations. #### How Has This Been Tested? UT and deploy on testbed, please see attached testbed results <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ``` sfp1 = platform_chassis.get_sfp(1)>>> platform_chassis = sonic_platform.platform.Platform().get_chassis() >>> sfp1 = platform_chassis.get_sfp(1) >>> sfp1.get_rx_disable() [True, False, False, False, False, False, False, False] >>> sfp1.rx_disable_channel(1, 1) True >>> sfp1.get_rx_disable() [True, False, False, False, False, False, False, False] >>> sfp1.rx_disable_channel(1, 0) True >>> sfp1.get_rx_disable() [False, False, False, False, False, False, False, False] >>> sfp1.rx_disable_channel(2, 0) True >>> sfp1.rx_disable_channel(2, 1) True >>> sfp1.get_rx_disable() [False, True, False, False, False, False, False, False] >>> sfp1.rx_disable_channel(2, 0) True >>> sfp1.get_rx_disable() [False, False, False, False, False, False, False, False] >>> ``` #### Additional Information (Optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFP(sff8472 attributes) transciever eeprom attribute support.