[Credo][Ycable] enhancement and error exception for some APIs #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts when merging 4eed20b into 030a382 - view on LGTM.com new alerts:
|
…herwise the manual switch count will be reset after each calling of get_switch_count_tor_a() Signed-off-by: Xinyu <[email protected]>
…g due to the variable EEPROM_ERROR was moved to YCable class Signed-off-by: Xinyu <[email protected]>
…align the fw version with the input fw file Signed-off-by: Xinyu <[email protected]>
Signed-off-by: Xinyu <[email protected]>
…o avoid acquire lock timeout error Signed-off-by: Xinyu <[email protected]>
Signed-off-by: Xinyu <[email protected]>
|
This pull request introduces 1 alert when merging ef98304 into 211d6bc - view on LGTM.com new alerts:
|
Signed-off-by: Xinyu <[email protected]>
Signed-off-by: Xinyu <[email protected]>
Signed-off-by: Xinyu <[email protected]>
Signed-off-by: Xinyu <[email protected]>
|
This pull request introduces 1 alert when merging 9da1144 into 211d6bc - view on LGTM.com new alerts:
|
Signed-off-by: Xinyu <[email protected]>
vdahiya12
approved these changes
Sep 16, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 17, 2022
Description fix the switch_count_tor_a() will always clear the counter after read issue. use YCable.EEPROM_ERROR due to the definition was moved. check and activate firmware by the inactive firmware version individually. add more error exception for activate_firmware() authored-by evan-lin [email protected] Signed-off-by: vaibhav-dahiya [email protected]
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Aug 10, 2023
Description fix the switch_count_tor_a() will always clear the counter after read issue. use YCable.EEPROM_ERROR due to the definition was moved. check and activate firmware by the inactive firmware version individually. add more error exception for activate_firmware() authored-by evan-lin [email protected] Signed-off-by: vaibhav-dahiya [email protected]
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
… once per task_worker/thread (sonic-net#303) This PR attempts for ycabled to have all swsscommon.Table and daemon_base.db_connect as just a single call in the thread instance for all task_workers For example all swsscommon calls to open Tables are moved as class object varables, which are reused when needed instead of opening the Table again in subroutines. self.config_db[asic_id] = daemon_base.db_connect("CONFIG_DB", namespace) This would help in avoiding unforeseen redis-errors Signed-off-by: vaibhav-dahiya [email protected] Description Motivation and Context How Has This Been Tested? Deploying changes on testbed and UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)