[SSD Generic] Add support for parsing nvme ssd model, health and temperature #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kebo Liu <[email protected]>
Signed-off-by: Kebo Liu <[email protected]>
keboliu
force-pushed
the
nvme-ssd-support
branch
from
099f992 to
27e2f0f
Compare
|
@prgeor kindly reminder to review and signoff |
prgeor
approved these changes
Mar 8, 2022
|
++ @sujinmkang |
6 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 7, 2022
Update sonic-platform-common submodule to pickup new commits: 01512ec [SSD]Enhance ssd_generic with more error handling to avoid python crash sonic-net/sonic-platform-common#271 ac3e7f1 [y_cable][Broadcom] update the BRCM y_cable driver to release 2.0 sonic-net/sonic-platform-common#263 573717a [Credo][Ycable] Fix Credo firmware download API download_firmware flag sonic-net/sonic-platform-common#269 a844f18 [xcvr] Add get_module_fw_info method to XcvrApi class. sonic-net/sonic-platform-common#267 35bad16 [sfputil]Refactoring read_porttab_mappings sonic-net/sonic-platform-common#264 83c4345 [SSD Generic] Add support for parsing nvme ssd model, health and temperature sonic-net/sonic-platform-common#265 5da31e1 [ycable][credo] Fix the is_link_active API for Credo Ycable sonic-net/sonic-platform-common#260 931c6ea [Y-Cable][Credo] add theading locker to support thread-safe calling, add SKU check for download_firmware API. sonic-net/sonic-platform-common#222 ff3aa75 Fix SFF8472 Enhanced Options sonic-net/sonic-platform-common#259 a8a83e9 [ssd] Allow individual vendor parsers to handle errors sonic-net/sonic-platform-common#252 Signed-off-by: Kebo Liu <[email protected]>
judyjoseph
pushed a commit
that referenced
this pull request
Apr 11, 2022
…erature (#265) * add support for parsing nvme ssd model, health and temperature Signed-off-by: Kebo Liu <[email protected]> * Add test case for sfp_ssd Signed-off-by: Kebo Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kebo Liu [email protected]
Description
enhance ssd_generic to support parsing NVME SSD info from smartctl output
Add test case for new added nvme parsing logic
Motivation and Context
in the output of smartctl, the related keys for NVME SSD are different:
The new change will look for the above keys when the device is nvme SSD
below is an example of smartctl output on an NVME SSD
How Has This Been Tested?
test ssdutil works as expected.
test show platform ssdhealth works as expected
Additional Information (Optional)